-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ability to enter a passage identifier to jump to it #8
Comments
I think this is basically a text input field that replaces the row of 24 book links |
While the existing Homer Reference Input is useful with the Reader, I think the Homer Reader needs to replace the book row with it too (as mentioned in the previous comment). Also probably needs a placeholder with an example of the format to use and we'll have to consider how to handle both books in #22 Finally, I think it should submit on hitting return. I shouldn't have to click on lookup (although have the button there is fine as otherwise it might not be clear what to do; but my natural instinct is to hit enter and it doesn't work) |
@jtauber so to be clear the action items are:
|
"(not sure exactly what)" -> "text input field that replaces the row of 24 book links" Instead of the row of 24 book links (which can only be used to retrieve a book at a time) put the text input / button from the separate widget there. |
Okay, after discussion, what I propose is: The text input field replaces the row of 24 book links but there is also a toggle to get the passage reference from the store. If this is toggled, the text input will be disabled (but will still show the passage). In short, this means each reader component can show its own passage OR get the passage from the store (where it is set by the Homer Reference Input). With this change, there is no reason for both the Reader and Homer Reader. The 2x2 is still useful (and will be more useful with this change and will fulfill #5). The Parallel reader isn't that interesting until we actually get to #17. |
but see #26 |
Note that this might need to be in the reader widget itself so it can be used in cases where there is more than one reader widget
Reference Model: A2
The text was updated successfully, but these errors were encountered: