Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded SVGs on the website are not clickable #79

Closed
danicheg opened this issue Jan 8, 2024 · 5 comments · Fixed by #82
Closed

Embedded SVGs on the website are not clickable #79

danicheg opened this issue Jan 8, 2024 · 5 comments · Fixed by #82
Assignees
Labels
bug docs Relates to any documentation of the project — microsite, readme, etc

Comments

@danicheg
Copy link
Collaborator

danicheg commented Jan 8, 2024

That's strange because when building the website locally, everything is fine, and SVGs are clickable as expected 🤔

scala-steward-implicit-searches-flamegraph.svg:125 Uncaught TypeError: Cannot read properties of undefined (reading 'firstChild')
    at g_to_text (scala-steward-implicit-searches-flamegraph.svg:125:36)
    at scala-steward-implicit-searches-flamegraph.svg:59:50
scala-steward-implicit-searches-flamegraph.svg:65 Uncaught TypeError: Cannot set properties of undefined (setting 'nodeValue')
    at scala-steward-implicit-searches-flamegraph.svg:65:33
@danicheg danicheg added bug docs Relates to any documentation of the project — microsite, readme, etc labels Jan 8, 2024
@danicheg
Copy link
Collaborator Author

danicheg commented Jan 9, 2024

I figured out that when the site is being published the FlameGraph SVG image is copied to the gh-pages branch, and it changes from the original one (compresses and results in missing XML structure). I manually replaced the image in gh-pages from main. But I'm unsure whether it will be replaced once again when the site is published.

@danicheg danicheg self-assigned this Jan 9, 2024
@danicheg
Copy link
Collaborator Author

danicheg commented Jan 9, 2024

And yes, it was overridden once again 😞 https://github.com/scalacenter/scalac-profiling/actions/runs/7457211480
As a temporary fix, we can manually change the image after every publishing. But doubtless, this is clunky.

@danicheg
Copy link
Collaborator Author

A while ago opened an issue in the mdoc project scalameta/mdoc#833.
Currently, the only workaround is to manually replace images in the gh-pages branch.

@danicheg
Copy link
Collaborator Author

Aaaand, it's fixed.

@SethTisue
Copy link
Collaborator

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug docs Relates to any documentation of the project — microsite, readme, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants