Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong line numbers using assertEquals when helper method declared in seperate file #855

Open
AugustNagro opened this issue Nov 26, 2024 · 2 comments

Comments

@AugustNagro
Copy link

AugustNagro commented Nov 26, 2024

When using a MUnit test inside a helper function that lives in a different file than the FunSuite subtype, the error output is very unhelpful.

I've made a minimal reproducer here: https://github.com/AugustNagro/munit-helper-bad-trace

MySuite:
+ this works 0.005s
  ==> X MySuite.this fails  0.021s munit.ComparisonFailException: /home/augustnagro/prog/test-projects/munit-helper-bad-trace/src/test/scala/MySuite.scala:4
  3:class MySuite extends munit.FunSuite {
  4:  mySharedTest(this, "Postgres")
  5:}
  values are not the same
  => Obtained
  abc
  => Diff (- obtained, + expected)
  -abc
  +abd
  at munit.Assertions.failComparison(Assertions.scala:278)
  [error] Failed: Total 2, Failed 1, Errors 0, Passed 1
  [error] Failed tests:
  [error] 	MySuite
  [error] (Test / test) sbt.TestsFailedException: Tests unsuccessful
  [error] Total time: 1 s, completed Nov 26, 2024, 12:09:19 AM

If assertEquals printed the stacktrace (like assert() and as suggested in #782 ), that would make things much better.

@AugustNagro AugustNagro changed the title Wrong line numbers using assertEquals in helper method declared in seperate file Wrong line numbers using assertEquals when helper method declared in seperate file Nov 26, 2024
@tgodzik
Copy link
Contributor

tgodzik commented Nov 26, 2024

I've been wondering whether hiding the stack trace is that useful. I think it was done to avoid having traces from munit, but this behaviour is flaky as seen here.

@AugustNagro
Copy link
Author

Yeah I also understand that I'm trying to do something against the grain here. If it were configurable at least that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants