From d1112a0d735f9693fc1c5e01632c2af89d287cff Mon Sep 17 00:00:00 2001 From: Sasha Harrison Date: Tue, 31 Aug 2021 14:00:46 -0700 Subject: [PATCH 1/3] change create from project endpoint to return an async job --- nucleus/__init__.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/nucleus/__init__.py b/nucleus/__init__.py index 8039c1c0..1f917f50 100644 --- a/nucleus/__init__.py +++ b/nucleus/__init__.py @@ -313,7 +313,13 @@ def create_dataset_from_project( if name: payload["name"] = name response = self.make_request(payload, "dataset/create_from_project") - return Dataset(response[DATASET_ID_KEY], self) + return Dataset(response[DATASET_ID_KEY], self), AsyncJob( + job_id=response[JOB_ID_KEY], + job_last_known_status=response[JOB_LAST_KNOWN_STATUS_KEY], + job_type=response[JOB_TYPE_KEY], + job_creation_time=response[JOB_CREATION_TIME_KEY], + client=self, + ) def create_dataset( self, From b00be626363944f59d5571e0d120b5d9841f57e4 Mon Sep 17 00:00:00 2001 From: Sasha Harrison Date: Tue, 31 Aug 2021 22:18:11 -0700 Subject: [PATCH 2/3] add missing argument --- nucleus/__init__.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/nucleus/__init__.py b/nucleus/__init__.py index 1f917f50..29f8a2d2 100644 --- a/nucleus/__init__.py +++ b/nucleus/__init__.py @@ -298,7 +298,11 @@ def delete_model_run(self, model_run_id: str): ) def create_dataset_from_project( - self, project_id: str, last_n_tasks: int = None, name: str = None + self, + project_id: str, + last_n_tasks: int = None, + name: str = None, + exclude_pending: bool = None, ) -> Dataset: """ Creates a new dataset based on payload params: @@ -312,6 +316,8 @@ def create_dataset_from_project( payload["last_n_tasks"] = str(last_n_tasks) if name: payload["name"] = name + if exclude_pending: + payload["exclude_pending"] = exclude_pending response = self.make_request(payload, "dataset/create_from_project") return Dataset(response[DATASET_ID_KEY], self), AsyncJob( job_id=response[JOB_ID_KEY], From 751690f9e156b64f48179e34d03c16644a2961b0 Mon Sep 17 00:00:00 2001 From: Sasha Harrison Date: Fri, 3 Sep 2021 07:58:25 -0700 Subject: [PATCH 3/3] minor improvements --- nucleus/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nucleus/__init__.py b/nucleus/__init__.py index 29f8a2d2..d1b53254 100644 --- a/nucleus/__init__.py +++ b/nucleus/__init__.py @@ -300,10 +300,10 @@ def delete_model_run(self, model_run_id: str): def create_dataset_from_project( self, project_id: str, - last_n_tasks: int = None, name: str = None, + last_n_tasks: int = None, exclude_pending: bool = None, - ) -> Dataset: + ) -> Tuple[Dataset, AsyncJob]: """ Creates a new dataset based on payload params: name -- A human-readable name of the dataset.