migrate smoke_tests to aws sdk v3

ISSUE: ZENKO-5054

Author: SylvainSenechal

tests/zenko_tests/node_tests/smoke_tests/vault_admin_and_IAM_API_tests/adminApi.js

@@ -1,6 +1,4 @@
-
 const async = require('async');
-
 const VaultClient = require('../../VaultClient');
 
 const clientAdmin = VaultClient.getAdminClient();
@@ -13,16 +11,21 @@ const accountInfo = {
 let iamClient = null;
 
 describe('Accounts: ', () => {
-    it('should be able create, generate credentials and delete an account', done => async.series([
-        next => clientAdmin.createAccount(accountName, accountInfo, next),
-        next => clientAdmin.generateAccountAccessKey(accountName, (err, res) => {
-            if (err) {
-                return next(err);
-            }
-
-            iamClient = VaultClient.getIamClient(res.id, res.value);
-            return next(null);
-        }),
-        next => VaultClient.deleteVaultAccount(clientAdmin, iamClient, accountName, next),
-    ], done));
+    it('should be able create, generate credentials and delete an account', done => {
+        async.series([
+            next => clientAdmin.createAccount(accountName, accountInfo, next),
+            next => clientAdmin.generateAccountAccessKey(accountName, (err, res) => {
+                if (err) {
+                    return next(err);
+                }
+                iamClient = VaultClient.getIamClient(res.id, res.value);
+                return next(null);
+            }),
+            next => {
+                VaultClient.deleteVaultAccount(clientAdmin, iamClient, accountName)
+                    .then(() => next())
+                    .catch(next);
+            },
+        ], done);
+    });
 });

tests/zenko_tests/node_tests/smoke_tests/vault_admin_and_IAM_API_tests/iamApi.js

@@ -1,5 +1,14 @@
 const async = require('async');
-
+const {
+    CreateUserCommand,
+    ListUsersCommand,
+    GetUserCommand,
+    UpdateUserCommand,
+    DeleteUserCommand,
+    CreateAccessKeyCommand,
+    ListAccessKeysCommand,
+    DeleteAccessKeyCommand,
+} = require('@aws-sdk/client-iam');
 const VaultClient = require('../../VaultClient');
 
 const clientAdmin = VaultClient.getAdminClient();
@@ -27,15 +36,17 @@ describe('IAM users: ', () => {
         return done();
     }));
 
-    afterEach(done => VaultClient.deleteVaultAccount(clientAdmin, iamAccountClient, accountName, done));
+    afterEach(async () => {
+        await VaultClient.deleteVaultAccount(clientAdmin, iamAccountClient, accountName);
+    });
 
-    it('should be able to perform CRUD operations on a user', done => async.series([
-        next => iamAccountClient.createUser({ UserName: userName }, next),
-        next => iamAccountClient.listUsers({}, next),
-        next => iamAccountClient.getUser({ UserName: userName }, next),
-        next => iamAccountClient.updateUser({ UserName: userName, NewPath: randomPath }, next),
-        next => iamAccountClient.deleteUser({ UserName: userName }, next),
-    ], done));
+    it('should be able to perform CRUD operations on a user', async () => {
+        await iamAccountClient.send(new CreateUserCommand({ UserName: userName }));
+        await iamAccountClient.send(new ListUsersCommand({}));
+        await iamAccountClient.send(new GetUserCommand({ UserName: userName }));
+        await iamAccountClient.send(new UpdateUserCommand({ UserName: userName, NewPath: randomPath }));
+        await iamAccountClient.send(new DeleteUserCommand({ UserName: userName }));
+    });
 });
 
 describe('IAM user - Access Keys: ', () => {
@@ -50,26 +61,23 @@ describe('IAM user - Access Keys: ', () => {
             return done(err);
         }
         iamAccountClient = VaultClient.getIamClient(externalAccessKey, externalSecretKey);
-        return iamAccountClient.createUser({ UserName: userName }, done);
+        return iamAccountClient.send(new CreateUserCommand({ UserName: userName }))
+            .then(() => done())
+            .catch(done);
     }));
 
-    afterEach(done => iamAccountClient.deleteUser(
-        { UserName: userName },
-        () => VaultClient.deleteVaultAccount(clientAdmin, iamAccountClient, accountName, done),
-    ));
+    afterEach(async () => {
+        await iamAccountClient.send(new DeleteUserCommand({ UserName: userName }));
+        await VaultClient.deleteVaultAccount(clientAdmin, iamAccountClient, accountName);
+    });
 
-    it('should be able to create, list and delete user access keys', done => async.series([
-        next => iamAccountClient.createAccessKey({ UserName: userName }, (err, result) => {
-            if (err) {
-                return next(err);
-            }
-            keyPair = result.AccessKey;
-            return next();
-        }),
-        next => iamAccountClient.listAccessKeys({ UserName: userName }, next),
-        next => iamAccountClient.deleteAccessKey({
+    it('should be able to create, list and delete user access keys', async () => {
+        const res = await iamAccountClient.send(new CreateAccessKeyCommand({ UserName: userName }));
+        keyPair = res.AccessKey;
+        await iamAccountClient.send(new ListAccessKeysCommand({ UserName: userName }));
+        await iamAccountClient.send(new DeleteAccessKeyCommand({
             UserName: userName,
             AccessKeyId: keyPair.AccessKeyId,
-        }, next),
-    ], done));
+        }));
+    });
 });