Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a linter check with github actions #38

Closed
wants to merge 4 commits into from

Conversation

slayer321
Copy link

fix #36
I have tested it on my side. and I didn't find any error.
If anything needs to be updated let me know.

@slayer321 slayer321 requested review from a team as code owners May 31, 2021 17:31
@Pradhvan
Copy link
Member

Pradhvan commented May 31, 2021

@slayer321 can you squash all four commits into one ?

Also it would great if you could ammend your commit and format it in a particular standard.

Currently we are still discussing the Commit pattern but you can follow this: http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html

One last thing in the branch name you seem to have added -patch-1-1 which could be have been -patch-1. It's always best to double check and ignore typos while committing and creating branches. 😄

Thanks for the PR. Looking forward to seeing the updated changes.

@slayer321
Copy link
Author

@Pradhvan is it ok if I just close this PR and open a new PR?

@Pradhvan
Copy link
Member

Pradhvan commented Jun 1, 2021

@slayer321 let's not do that. Let's try to update the existing PR.

Do you need help with anything?

@slayer321 slayer321 closed this Jun 1, 2021
@slayer321 slayer321 deleted the slayer321-patch-1-1 branch June 1, 2021 16:49
@slayer321
Copy link
Author

I think that I just messed it up 😅 . I change the branch name from slayer321-patch-1-1 to slayer321-patch-1 and now the PR is showing close.

@slayer321 let's not do that. Let's try to update the existing PR.

Do you need help with anything?

Yes, all the changes that I did in the .workflow dir were on the GitHub website and I didn't use git bash for this. So now I don't have that branch on my git bash.
I checked how to squash all my four commits to one, but I need this branch and I don't have this branch on my git bash so how can it be done?

@slayer321 slayer321 restored the slayer321-patch-1-1 branch June 2, 2021 04:59
@Pradhvan
Copy link
Member

Pradhvan commented Jun 3, 2021

@slayer321 great! you did found a way to restore a branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a linter check with github actions
2 participants