Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Improving response time #277

Open
jonigkeit opened this issue Jan 11, 2019 · 3 comments
Open

Improving response time #277

jonigkeit opened this issue Jan 11, 2019 · 3 comments
Labels
approved The change has been approved enhancement Notice General information

Comments

@jonigkeit
Copy link
Contributor

jonigkeit commented Jan 11, 2019

To achieve minimal response time the following HTTP Header X-Set-Root can be set to the value of the root attribute of the setId element.
For instance the submission

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<ClinicalDocument classCode="DOCCLIN" moodCode="EVN" xmlns="urn:hl7-org:v3">
   ...
    <setId root="a3fce675-4097-41ee-95e1-62f88d2d54cb" assigningAuthorityName="Region Nordjylland"/>
   ...
<ClinicalDocument/>

would set X-Set-Id: a3fce675-4097-41ee-95e1-62f88d2d54cb

if you have multiple sets in one XDR request you SHALL NOT set the header.

@jonigkeit jonigkeit added enhancement approved The change has been approved Notice General information labels Jan 11, 2019
@jonigkeit jonigkeit pinned this issue Jan 11, 2019
@jonigkeit jonigkeit changed the title Improved response time Improving response time Jan 11, 2019
@RasmusThernoe
Copy link

What is the expected response time from respectively "PatientHealthcareReportingService" and "PatientHealthcareValidateReportingService" without this new header element in production?

What is the expected response time from respectively "PatientHealthcareReportingService" and "PatientHealthcareValidateReportingService" with this new header element in production?

@RasmusThernoe
Copy link

How much does this new header element improve response times?

Is this new header element necessary to obtain the response times communicated by SDS? (150.000 CDA documents per hour)

@TueCN
Copy link
Contributor

TueCN commented Jan 23, 2019

@RasmusThernoe it is hard to say as it depends on the current workload of the service. If the service is idle, it may only improve response time by 10ms, but if the service is hard pressed, it may improve it much more.

Basically, setting the header offloads some initial load-balancing work from the service itself.

We can try and do some tests to see what the improvements are in our DXC internal load-balanced test environment, but such a test would have lower priority than fixing bugs :)

Note: https://lprws-test.sds.dsdn.dk is a SDS owned test environment, which is not load-balanced, so you will not see any effect of setting the header on this environment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved The change has been approved enhancement Notice General information
Projects
None yet
Development

No branches or pull requests

3 participants