Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shoes Drawables should be under Shoes::Types #451

Open
noahgibbs opened this issue Nov 11, 2023 · 0 comments
Open

Shoes Drawables should be under Shoes::Types #451

noahgibbs opened this issue Nov 11, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers KWoC-2023 IIT Kharagpur Winter of Code 2023 - good for new contributors

Comments

@noahgibbs
Copy link
Collaborator

In Shoes3, drawables (e.g. Button and EditLine) were under Shoes::Types. Right now the Shoes namespace in the online docs (https://scarpe-team.github.io/scarpe/Shoes.html) is really hard to navigate. The left bar is packed with drawables and error classes, so it's really hard to understand the structure.

I'm working on fixing the error classes thing (see PR #449), but we should also do what Shoes3 did and move all the drawables into Shoes::Types::Button, Shoes::Types::EditLine, etc. Shoes::Types should be a module in Lacci.

The main place to change this is in all the Shoes::Drawable source files (e.g. lacci/lib/shoes/drawables/button.rb). But we may also need to change it in places where we look up classes by name (e.g. https://github.com/scarpe-team/scarpe/blob/main/lacci/lib/shoes/drawable.rb#L45). I think that code will be fine?. Luckily it's used by nearly everything, so if it's a problem, the tests should catch it.

I think Shoes::Drawable probably should not go into Types, just so it's more visible in the docs as being its own thing. So probably just the stuff in lacci/lib/shoes/drawables.

@noahgibbs noahgibbs added bug Something isn't working good first issue Good for newcomers KWoC-2023 IIT Kharagpur Winter of Code 2023 - good for new contributors labels Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers KWoC-2023 IIT Kharagpur Winter of Code 2023 - good for new contributors
Projects
None yet
Development

No branches or pull requests

1 participant