Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shoes size mappings should be in Scarpe-Components #505

Open
noahgibbs opened this issue Dec 13, 2023 · 0 comments
Open

Shoes size mappings should be in Scarpe-Components #505

noahgibbs opened this issue Dec 13, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers KWoC-2023 IIT Kharagpur Winter of Code 2023 - good for new contributors

Comments

@noahgibbs
Copy link
Collaborator

Right now we use the mappings of Shoes names to sizes (e.g. banner, subtitle, inscription) in several different places. For instance, I see it in scarpe-components/lib/scarpe/components/calzini.rb, scarpe-components/lib/scarpe/components/tiranti.rb, lacci/lib/shoes/drawables/para.rb, lib/scarpe/wv/span.rb and lib/scarpe/wv/para.rb.

We should have a Scarpe Component with the size mapping, and these other places should all use it and depend on it. In a few places, the data structure is slightly different. For instance, Tiranti maps the names to size and HTML tag (e.g. p, h1, h2). But we can still get the size information from one place, not keep a separate copy everywhere.

@noahgibbs noahgibbs added enhancement New feature or request good first issue Good for newcomers KWoC-2023 IIT Kharagpur Winter of Code 2023 - good for new contributors labels Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers KWoC-2023 IIT Kharagpur Winter of Code 2023 - good for new contributors
Projects
None yet
Development

No branches or pull requests

1 participant