Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat Shoes styles should print a warning to console #506

Open
noahgibbs opened this issue Dec 13, 2023 · 0 comments
Open

Repeat Shoes styles should print a warning to console #506

noahgibbs opened this issue Dec 13, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers KWoC-2023 IIT Kharagpur Winter of Code 2023 - good for new contributors

Comments

@noahgibbs
Copy link
Collaborator

In lacci/lib/shoes/drawable.rb, in class-method shoes_style, we register a shoes style for a drawable class.

Right now, it says that if the style is already there, return without doing anything ("return if linkable_properties_hash[name]").

Instead, if the style is already there we should print a warning to the console or the log. If the feature or validator doesn't match, it should raise an exception instead of printing a warning.

There are pretty certainly repeated shoes styles currently, places where the parent class adds a shoes style and then a child class adds the same one. I've gotten rid of several already. It would be good to find them and get rid of the rest.

@noahgibbs noahgibbs added enhancement New feature or request good first issue Good for newcomers KWoC-2023 IIT Kharagpur Winter of Code 2023 - good for new contributors labels Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers KWoC-2023 IIT Kharagpur Winter of Code 2023 - good for new contributors
Projects
None yet
Development

No branches or pull requests

1 participant