From e3f2b7a970dadb3ea9f8ee0ae600531f1bba16df Mon Sep 17 00:00:00 2001 From: Nick Schwaderer Date: Tue, 8 Oct 2024 11:20:05 +0100 Subject: [PATCH] Remove rubocop --- .github/workflows/ci.yml | 15 ------ .rubocop.yml | 94 ---------------------------------- Rakefile | 42 ++++++--------- lacci/Gemfile | 2 - lacci/Gemfile.lock | 30 +---------- scarpe-components/Gemfile | 2 - scarpe-components/Gemfile.lock | 32 +----------- 7 files changed, 19 insertions(+), 198 deletions(-) delete mode 100644 .rubocop.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 07c715fb1..8db9099fd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -39,18 +39,3 @@ jobs: with: name: test failure logs path: logger/test_failure*.out.log - # linter: - # name: Linter - # runs-on: macos-latest - # timeout-minutes: 10 - # steps: - # - name: Install dependencies - # run: brew install pkg-config portaudio - # - name: Checkout code - # uses: actions/checkout@v4 - # - name: Setup Ruby and install gems - # uses: ruby/setup-ruby@v1 - # with: - # bundler-cache: true - # - name: Run linter - # run: bundle exec rubocop diff --git a/.rubocop.yml b/.rubocop.yml deleted file mode 100644 index 14c4e4de6..000000000 --- a/.rubocop.yml +++ /dev/null @@ -1,94 +0,0 @@ -inherit_gem: - rubocop-shopify: rubocop.yml - -AllCops: - TargetRubyVersion: 3.2 - SuggestExtensions: false - Exclude: - - 'bin/**/*' - - 'exe/**/*' - # - 'examples/**/*' Since I'm only doing this locally. - - 'docs/**/*' - -Layout/LineLength: - Max: 150 - -Style/RedundantHeredocDelimiterQuotes: - Enabled: false - -Style/MissingRespondToMissing: - Enabled: false - -Metrics/ParameterLists: - Enabled: false - -Style/ParallelAssignment: - Enabled: false - - - -Style/MethodCallWithArgsParentheses: - Enabled: false - -Style/GlobalVars: - Enabled: false - -Style/CommandLiteral: - Enabled: false - -Security/Eval: - Enabled: false - -Style/LineEndConcatenation: - Enabled: false - -Style/ClassVars: - Enabled: false - -Naming/AccessorMethodName: - Enabled: false - -Style/RedundantSelf: - Enabled: false - -Style/ClassMethodsDefinitions: - Enabled: false - -Style/SpecialGlobalVars: - Enabled: false - -Style/CaseEquality: - Enabled: false - -Style/RedundantConstantBase: - Enabled: false - -Style/EmptyElse: - Enabled: false - -Metrics/BlockNesting: - Enabled: false - -Layout/EmptyLinesAroundExceptionHandlingKeywords: - Enabled: false - -Style/RedundantBegin: - Enabled: false - -Layout/LeadingCommentSpace: - Enabled: false - -Style/FormatString: - Enabled: false - -Style/RegexpLiteral: - Enabled: false - -Style/ReturnNil: - Enabled: false - -Style/ClassAndModuleChildren: - Enabled: false - -Layout/EmptyLineBetweenDefs: - Enabled: false diff --git a/Rakefile b/Rakefile index e97c52d9b..49905de07 100644 --- a/Rakefile +++ b/Rakefile @@ -1,8 +1,7 @@ # frozen_string_literal: true -require "bundler/gem_tasks" -require "rake/testtask" -require "rubocop/rake_task" +require 'bundler/gem_tasks' +require 'rake/testtask' # Rakefile @@ -13,20 +12,18 @@ task :ci_test do system('brew install pkg-config portaudio') - puts " \033[1;32;4;47mCheckout Code\033[0m " system('git checkout main') - puts " \033[1;32;4;47mSetup Ruby and install Gems\033[0m " system('bundle install') # Run tests - + puts " \033[1;32;4;47mRun Lacci Tests\033[0m " @@ -38,19 +35,16 @@ task :ci_test do system('CI_RUN=true bundle exec rake component_test') - puts " \033[1;32;4;47mRun Scarpe Tests\033[0m " system('CI_RUN=true bundle exec rake test') - puts " \033[1;32;4;47mCheck HTML Output\033[0m " system('bundle exec rake test:check_html_fixtures') - puts " \033[1;32;4;47mUpload Fail logs\033[0m " @@ -58,37 +52,35 @@ task :ci_test do end Rake::TestTask.new(:test) do |t| - t.libs << "test" - t.libs << "lib" - t.test_files = FileList["test/**/test_*.rb"] + t.libs << 'test' + t.libs << 'lib' + t.test_files = FileList['test/**/test_*.rb'] end Rake::TestTask.new(:lacci_test) do |t| - t.libs << "lacci/test" - t.libs << "lacci/lib" - t.test_files = FileList["lacci/test/**/test_*.rb"] + t.libs << 'lacci/test' + t.libs << 'lacci/lib' + t.test_files = FileList['lacci/test/**/test_*.rb'] end Rake::TestTask.new(:component_test) do |t| - t.libs << "scarpe-components/test" - t.libs << "scarpe-components/lib" - t.test_files = FileList["scarpe-components/test/**/test_*.rb"] + t.libs << 'scarpe-components/test' + t.libs << 'scarpe-components/lib' + t.test_files = FileList['scarpe-components/test/**/test_*.rb'] end namespace :test do desc 'Regenerate HTML fixtures' - task :regenerate_html_fixtures do |t| - ENV['SELECTED_FILE'] = ARGV[-1] if ARGV[-1].include?(".rb") + task :regenerate_html_fixtures do |_t| + ENV['SELECTED_FILE'] = ARGV[-1] if ARGV[-1].include?('.rb') load 'tasks/regenerate_html_fixtures.rb' end desc 'Check HTML fixtures against latest output' - task :check_html_fixtures do |t| - ENV['SELECTED_FILE'] = ARGV[-1] if ARGV[-1].include?(".rb") + task :check_html_fixtures do |_t| + ENV['SELECTED_FILE'] = ARGV[-1] if ARGV[-1].include?('.rb') load 'tasks/check_html_fixtures.rb' end end -RuboCop::RakeTask.new - -task default: [:test, :lacci_test, :component_test] +task default: %i[test lacci_test component_test] diff --git a/lacci/Gemfile b/lacci/Gemfile index e982948e0..2383f4bbc 100644 --- a/lacci/Gemfile +++ b/lacci/Gemfile @@ -17,8 +17,6 @@ group :development do gem "yard" gem "redcarpet" gem "debug" - gem "rubocop", "~> 1.21" - gem "rubocop-shopify" #gem "commonmarker" #gem "github-markup" end diff --git a/lacci/Gemfile.lock b/lacci/Gemfile.lock index 0c30c5f36..a841279be 100644 --- a/lacci/Gemfile.lock +++ b/lacci/Gemfile.lock @@ -13,7 +13,6 @@ GEM remote: https://rubygems.org/ specs: ansi (1.5.0) - ast (2.4.2) builder (3.2.4) debug (1.8.0) irb (>= 1.5.0) @@ -21,46 +20,21 @@ GEM io-console (0.6.0) irb (1.7.2) reline (>= 0.3.6) - json (2.6.3) - language_server-protocol (3.17.0.3) minitest (5.18.1) minitest-reporters (1.6.0) ansi builder minitest (>= 5.0) ruby-progressbar - parallel (1.23.0) - parser (3.2.2.3) - ast (~> 2.4.1) - racc - racc (1.7.1) - rainbow (3.1.1) rake (13.0.6) redcarpet (3.6.0) - regexp_parser (2.8.1) reline (0.3.6) io-console (~> 0.5) - rexml (3.2.5) - rubocop (1.54.1) - json (~> 2.3) - language_server-protocol (>= 3.17.0) - parallel (~> 1.10) - parser (>= 3.2.2.3) - rainbow (>= 2.2.2, < 4.0) - regexp_parser (>= 1.8, < 3.0) - rexml (>= 3.2.5, < 4.0) - rubocop-ast (>= 1.28.0, < 2.0) - ruby-progressbar (~> 1.7) - unicode-display_width (>= 2.4.0, < 3.0) - rubocop-ast (1.29.0) - parser (>= 3.2.1.0) - rubocop-shopify (2.14.0) - rubocop (~> 1.51) ruby-progressbar (1.13.0) - unicode-display_width (2.4.2) yard (0.9.34) PLATFORMS + arm64-darwin-21 x86_64-darwin-22 DEPENDENCIES @@ -70,8 +44,6 @@ DEPENDENCIES minitest-reporters rake (~> 13.0) redcarpet - rubocop (~> 1.21) - rubocop-shopify scarpe-components! yard diff --git a/scarpe-components/Gemfile b/scarpe-components/Gemfile index bddf6a39a..132f6a835 100644 --- a/scarpe-components/Gemfile +++ b/scarpe-components/Gemfile @@ -20,6 +20,4 @@ end group :development do gem "debug" - gem "rubocop", "~> 1.21" - gem "rubocop-shopify" end diff --git a/scarpe-components/Gemfile.lock b/scarpe-components/Gemfile.lock index c07184ea5..f9f9305db 100644 --- a/scarpe-components/Gemfile.lock +++ b/scarpe-components/Gemfile.lock @@ -13,8 +13,6 @@ GEM remote: https://rubygems.org/ specs: ansi (1.5.0) - ast (2.4.2) - base64 (0.1.1) builder (3.2.4) debug (1.8.0) irb (>= 1.5.0) @@ -23,51 +21,25 @@ GEM irb (1.8.0) rdoc (~> 6.5) reline (>= 0.3.6) - json (2.6.3) - language_server-protocol (3.17.0.3) minitest (5.19.0) minitest-reporters (1.6.1) ansi builder minitest (>= 5.0) ruby-progressbar - parallel (1.23.0) - parser (3.2.2.3) - ast (~> 2.4.1) - racc psych (5.1.0) stringio - racc (1.7.1) - rainbow (3.1.1) rake (13.0.6) rdoc (6.5.0) psych (>= 4.0.0) - regexp_parser (2.8.1) reline (0.3.8) io-console (~> 0.5) - rexml (3.2.6) - rubocop (1.56.2) - base64 (~> 0.1.1) - json (~> 2.3) - language_server-protocol (>= 3.17.0) - parallel (~> 1.10) - parser (>= 3.2.2.3) - rainbow (>= 2.2.2, < 4.0) - regexp_parser (>= 1.8, < 3.0) - rexml (>= 3.2.5, < 4.0) - rubocop-ast (>= 1.28.1, < 2.0) - ruby-progressbar (~> 1.7) - unicode-display_width (>= 2.4.0, < 3.0) - rubocop-ast (1.29.0) - parser (>= 3.2.1.0) - rubocop-shopify (2.14.0) - rubocop (~> 1.51) ruby-progressbar (1.13.0) stringio (3.0.8) - unicode-display_width (2.4.2) webrick (1.8.1) PLATFORMS + arm64-darwin-21 x86_64-darwin-22 DEPENDENCIES @@ -76,8 +48,6 @@ DEPENDENCIES minitest (~> 5.0) minitest-reporters rake (~> 13.0) - rubocop (~> 1.21) - rubocop-shopify scarpe-components! webrick