Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassCastException at random time? #15

Open
realkarmakun opened this issue Aug 5, 2021 · 4 comments
Open

ClassCastException at random time? #15

realkarmakun opened this issue Aug 5, 2021 · 4 comments

Comments

@realkarmakun
Copy link

realkarmakun commented Aug 5, 2021

After running trevor for a while (1700+ players, Velocity). Getting this error for some players. Can't quite understand what it's about. Maybe pool is too small?

[19:59:48 INFO]: [connected player] MakS_na_priKole (/217.66.156.235:5566) has connected
[19:59:48 ERROR]: Some errors occurred whilst posting event LoginEvent{player=[connected player] MakS_na_priKole (/217.66.156.235:5566), result=allowed}.
[19:59:48 ERROR]: #1: 

java.util.concurrent.CompletionException: java.lang.ClassCastException
        at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314) ~[?:?]
        at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:319) ~[?:?]
        at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:645) ~[?:?]
        at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506) ~[?:?]
        at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2137) ~[?:?]
        at co.schemati.trevor.common.database.redis.RedisDatabase.lambda$open$0(RedisDatabase.java:75) ~[?:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) ~[?:?]
        at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630) ~[?:?]
        at java.lang.Thread.run(Thread.java:832) [?:?]
Caused by: java.lang.ClassCastException
@realkarmakun
Copy link
Author

[09:47:41] [Netty epoll Worker #13/INFO]: [connected player] M41 (/95.133.137.187:50097) has connected
[09:47:41] [Velocity Event Executor - #1/ERROR]: Some errors occurred whilst posting event LoginEvent{player=[connected player] M41 (/95.133.137.187:50097), result=allowed}.
[09:47:41] [Velocity Event Executor - #1/ERROR]: #1: 

java.util.concurrent.CompletionException: java.lang.ClassCastException: class java.lang.Long cannot be cast to class [B (java.lang.Long and [B are in module java.base of loader 'bootstrap')
	at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314) ~[?:?]
	at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:319) ~[?:?]
	at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:645) ~[?:?]
	at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506) ~[?:?]
	at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2137) ~[?:?]
	at co.schemati.trevor.common.database.redis.RedisDatabase.lambda$open$0(RedisDatabase.java:75) ~[?:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) ~[?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630) ~[?:?]
	at java.lang.Thread.run(Thread.java:832) [?:?]
Caused by: java.lang.ClassCastException: class java.lang.Long cannot be cast to class [B (java.lang.Long and [B are in module java.base of loader 'bootstrap')
	at redis.clients.jedis.Connection.getStatusCodeReply(Connection.java:201) ~[?:?]
	at redis.clients.jedis.Jedis.hmset(Jedis.java:813) ~[?:?]
	at co.schemati.trevor.common.database.redis.RedisConnection.create(RedisConnection.java:75) ~[?:?]
	at co.schemati.trevor.common.proxy.DatabaseProxyImpl.lambda$onPlayerConnect$0(DatabaseProxyImpl.java:47) ~[?:?]
	at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:642) ~[?:?]
	... 9 more

@realkarmakun
Copy link
Author

Alright, probably related issue redis/jedis#122

@realkarmakun
Copy link
Author

Also related but a bit more fresh redis/jedis#186

@realkarmakun
Copy link
Author

So after some research this issue appears when someone trying to to something with broken connections. Can it be related to executor service having 8 hardcoded?

this.executor = Executors.newScheduledThreadPool(8);

Maybe trevor just can't handle amount of players because of small thread pool. Which results in some kind of race condition. Right now testing this theory with 1 thread in executor service and 100 players.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant