Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BetterPlayer colliding with textToSpeech plugin as text is being read #65

Open
mwolffalonso opened this issue Jun 15, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mwolffalonso
Copy link

Is your feature request related to a problem? Please describe.
I cannot use it embedded better_player in TweetView because of an AudioFocus issue i still cannot work out. It seems like BetterPlayer is colliding with the ongoing textToSpeech being read.

Thanks

Describe the solution you'd like
Something to avoid giving focus to better_player before the video is tapped

Describe alternatives you've considered
Some EmbeddedTweetView option to not autoload or autoplay
Or an onTapVideo option to process video myself outside the tweet

Additional context
useVideoPlayer: false could be an option but in iOS the video displays in full screen without possibility to dismiss and cannot return to my aplication.

@mwolffalonso mwolffalonso added the enhancement New feature or request label Jun 15, 2021
@kawa89
Copy link
Collaborator

kawa89 commented Jun 17, 2021

useVideoPlayer: false could be an option but in iOS the video displays in full screen without possibility to dismiss and cannot return to my aplication.
I think this is a problem. Will try to fix it in the next release.

@kawa89 kawa89 added bug Something isn't working and removed enhancement New feature or request labels Jun 17, 2021
@kawa89 kawa89 self-assigned this Jun 17, 2021
@mwolffalonso
Copy link
Author

Hello @kawa89, related to:

"in iOS the video displays in full screen without possibility to dismiss and cannot return to my aplication."

I have added a Scaffold widget with an empty AppBar and with that I now see a navigation back button item to dismiss the fullscreen photo or video.
I have forked the repository, updated the code and made a pull request to master. Is that ok? Or should i do something else? Sorry this is my first forking...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants