Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the injected iframe and make the popup view optional #63

Open
tinywrkb opened this issue Nov 23, 2020 · 2 comments
Open

Bring back the injected iframe and make the popup view optional #63

tinywrkb opened this issue Nov 23, 2020 · 2 comments

Comments

@tinywrkb
Copy link

2fa0ae0 pretty much broke for me the overlay behavior of the extension.
Basically, Chrome's popup windows under Wayland (Linux) are not being set as floating windows which creates a problem with tiling window managers, specifically, Sway.
What's happening is that the new, supposedly popup window, is opened as a tiled window, snapped to the side of the parent Chrome window, that's instead of floating above the parent Chrome window.
The workaround for this is to tell the window manager to set the new window as floating based on its title (Google Translate) but this affects any Chrome window with the same title, and is also too slow so the new window is still snapped to the size of the parent window before floating, so it's causing the parent window to resize down and back.

Any chance that the iframe view will be brought back? shouldn't this also help with performance as opening a new window, which is sandboxed, is more costly than an iframe?

@schomery
Copy link
Owner

Unfortunately, I couldn't find a way to properly load Google Translate on iframes. See #59 for instance. If it still works for you, try to load the old version locally; https://github.com/schomery/dictionary/tree/master/old%20-%202

@tinywrkb
Copy link
Author

The 0.4.3 version is working without a problem in Chrome 88 so it would be nice if the iframe code path could be added back as a configurable option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants