Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI job "Release-Tarball" no longer works #352

Open
auerswal opened this issue Oct 5, 2024 · 4 comments
Open

CI job "Release-Tarball" no longer works #352

auerswal opened this issue Oct 5, 2024 · 4 comments

Comments

@auerswal
Copy link
Collaborator

auerswal commented Oct 5, 2024

After merging pull request #350, the automatically triggered CI job "Release-Tarball" failed with the error that it uses a deprecated API version:

This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

fping-error

@gsnw-sebast
Copy link
Collaborator

Pull request #355 was created for this purpose. However, the question is whether the intermediate step should be taken via v3 and we then go to v4 or directly to v4.

Version v4 apparently requires uniqueness in the name variable, which can be achieved via ${{ matrix.os }} in name.

Untested

- uses: actions/upload-artifact@v2
        with:
          name: dist-${{ matrix.os }}
          path: fping-*.tar.gz

@auerswal
Copy link
Collaborator Author

I would suggest to merge PR #355 and see if it works as intended. Then we can look into using v4. Since you already started looking into it, feel free to create a pull request.

@gsnw-sebast
Copy link
Collaborator

gsnw-sebast commented Nov 15, 2024

Version 4 works name: dist-${{ github.sha }} #360

@auerswal
Copy link
Collaborator Author

If I understand everything correctly, the CI job already works again. We can leave this issue open until the change to version 4 is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants