Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor joins to use pd-merge #45

Open
genmeblog opened this issue Jul 12, 2021 · 0 comments
Open

Refactor joins to use pd-merge #45

genmeblog opened this issue Jul 12, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@genmeblog
Copy link
Member

https://techascent.github.io/tech.ml.dataset/tech.v3.dataset.join.html#var-pd-merge

Currently joins on multiple columns are made using tmd/left-join (or right) iteratively column by column. Switching to a pd-merge will allow more optimal path.

PRs welcome.
@genmeblog genmeblog added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@genmeblog