Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider exposing intern/wolfram-fn in the public API #129

Open
holyjak opened this issue Sep 28, 2024 · 2 comments
Open

Consider exposing intern/wolfram-fn in the public API #129

holyjak opened this issue Sep 28, 2024 · 2 comments
Labels
enhancement New feature or request UX User/developer eXperience

Comments

@holyjak
Copy link
Member

holyjak commented Sep 28, 2024

While wolframite.impl.wolfram-syms.intern/wolfram-fn is primarily an internal function, it can be useful, f.ex. to create wrapper vars for symbols that are not in wolframite.wolfram, such as this case:

(def StringToMReal (wolframite.impl.wolfram-syms.intern/wolfram-fn 'Internal/StringToMReal))
(wl/eval (StringToMReal "12.34"))
;; => 12.34

It doesn't seem to belong to the core ns itself. Perhaps wolframite.utils or some such?!

TODO: If we do this, then update the demo_analysis_cycling.clj using it.

@holyjak holyjak added the UX User/developer eXperience label Sep 28, 2024
@holyjak holyjak added the enhancement New feature or request label Nov 15, 2024
@light-matters
Copy link
Contributor

I don't think this should be in the 'api' as such because it seems more like an advanced developer option. Maybe this could be a subbrach of the API, e.g. api.v1.advanced...?

@holyjak
Copy link
Member Author

holyjak commented Nov 22, 2024

I would wait with introducing new namespaces until we have more things to put there.

But since we now have the api ns, perhaps we could put the intern/wolfram-fn into the underlying wolframite.core ns?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UX User/developer eXperience
Projects
None yet
Development

No branches or pull requests

2 participants