Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webapp seem broken ? #208

Closed
Carreau opened this issue May 3, 2024 · 4 comments
Closed

Webapp seem broken ? #208

Carreau opened this issue May 3, 2024 · 4 comments

Comments

@Carreau
Copy link

Carreau commented May 3, 2024

Using the example of scikit-hep/hist

https://scientific-python.github.io/repo-review/?repo=scikit-hep%2Fhist&branch=main

I get

Traceback (most recent call last):
  File "/lib/python311.zip/_pyodide/_base.py", line 468, in eval_code
    .run(globals, locals)
     ^^^^^^^^^^^^^^^^^^^^
  File "/lib/python311.zip/_pyodide/_base.py", line 310, in run
    coroutine = eval(self.code, globals, locals)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "", line 5, in 
  File "", line 7, in __init__
  File "/lib/python3.11/site-packages/repo_review/ghpath.py", line 59, in __post_init__
    val: io.StringIO = self.open_url(url)
                       ^^^^^^^^^^^^^^^^^^
  File "/lib/python3.11/site-packages/repo_review/ghpath.py", line 53, in open_url
    with urllib.request.urlopen(url) as response:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/lib/python311.zip/urllib/request.py", line 216, in urlopen
    return opener.open(url, data, timeout)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/lib/python311.zip/urllib/request.py", line 519, in open
    response = self._open(req, data)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/lib/python311.zip/urllib/request.py", line 541, in _open
    return self._call_chain(self.handle_open, 'unknown',
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/lib/python311.zip/urllib/request.py", line 496, in _call_chain
    result = func(*args)
             ^^^^^^^^^^^
  File "/lib/python311.zip/urllib/request.py", line 1419, in unknown_open
    raise URLError('unknown url type: %s' % type)
urllib.error.URLError: 

Edit: works from the CLI, so unsure.

@henryiii
Copy link
Collaborator

henryiii commented May 3, 2024

Same is happening here: https://scientific-python.github.io/repo-review/?repo=scikit-hep%2Fhist&branch=main - not sure what changed, but it's not picking up the injection of open_url. The next version modifies this a bit in #206, but that's not out yet, so no idea why it's broken yet.

@henryiii
Copy link
Collaborator

henryiii commented May 3, 2024

Actually, I understand why the local demo is broken - it expects the unreleased version of repo-review. Ahh, your link is the unreleased version too! That's why. I thought you were pointing at the dev guide. Probably should just make a release, then.

@henryiii
Copy link
Collaborator

henryiii commented May 4, 2024

0.11 is out which fixes this.

@henryiii henryiii closed this as completed May 4, 2024
@Carreau
Copy link
Author

Carreau commented May 4, 2024

Ah, sorry ! thanks for the quick fix !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants