Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dom-pixels and node-pixels don't accept same type string sets #33

Open
benwiley4000 opened this issue Jun 26, 2017 · 0 comments
Open

dom-pixels and node-pixels don't accept same type string sets #33

benwiley4000 opened this issue Jun 26, 2017 · 0 comments
Labels

Comments

@benwiley4000
Copy link
Collaborator

dom-pixels.js accepts the following types:

  • '.GIF'
  • anything else

node-pixels.js accepts the following types:

  • 'image/png'
  • 'image/jpg'
  • 'image/jpeg'
  • 'image/gif'
  • 'image/bmp'

Clearly this is a problem if I want to run the same script on the server and client.

The node-pixels version seems more thought-out - perhaps this should be used instead for the client and the '.GIF' option should be deprecated and phased out in the next major version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant