-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis credits #159
Comments
There's a race condition between travis-ci & GHA I did not think about when crafting #139 : Because building cmake python package requires cmake, the following line exists (required for manylinux1 only on linux): cmake-python-distributions/pyproject.toml Line 24 in be7c3ff
We could pin its version or require it only for x86/x64. I will also open a PR for with GHA emulation just to see how much time it takes. |
@henryiii, |
The GHA workflow takes a bit more than 2 hours with emulation. IMHO, this takes too long for PR but should be OK for releases. Here's what I'm thinking:
Given almost everything happens in a docker container, it should not matter wether we're using GHA emulated or Travis-CI and I think there's very little risk with what's proposed. The cron job would ensure that we're not hitting a qemu issue now & then. |
I'm just a maintainer on the PyPI package, so can't add you there. You can send it to me and I can upload it, or @jcfr or @thewtex could add you. That plan sounds good. The "only upload if all wheels are built" part, especially. Adding three parallel 2 hour jobs isn't awful for release-only. We also are reducing our unnecessary usage of Travis. I did try to build locally on my mac, but had an illegal instruction (even just trying to open that ppc manylinux image). |
I sent you a google drive link along with the sha256sum
that's something I've certainly seen before and one of the quirks of using qemu.
I will update my PR for this. |
To streamline releases:
|
@jcfr, thanks. Unfortunately, I was away for a long week-end and the link to join those projects expired before I could accept. Can you send those again please ? |
Of course, I just sent new invites :) |
@jcfr, thanks, I could upload the missing wheel to PyPI.
@thewtex, |
Travis CI is not used anymore |
Thanks for cleanup the issue tracker 🙏 |
I've released CMake 3.20.5, which worked beautifully on the GitHub Actions backend, which the exception of a missnamed deployment secret (so I was just able to download the artifacts and push those to PyPI manually, fantastic! I've added a new key with the proper name - in the future, we can change the name in the workflow to one of the other two options now).
However, the PowerPC job on Travis failed due to networking issues, and I restarted it several times, and now have an "out of credits" message and can't build the PowerPC arch for 3.20.5 (so if you are reading this and need PowerPC, use 3.20.4 for the moment). Here are some ideas:
The text was updated successfully, but these errors were encountered: