fix: build from sources with --no-binary=ninja
#276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeut
force-pushed
the
no-binary-ninja
branch
from
388c5e2
to
406766f
Compare
mayeut
force-pushed
the
no-binary-ninja
branch
from
3349c7b
to
e742dc2
Compare
mayeut
changed the title
--no-binary=ninja
|
@henryiii, I think ninja & cmake are special enough that using a custom backend wrapper on scikit-build-core is more appropriate than having new options in scikit-build-core. You probably have much more insight, what do you think ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #274
Ninja shall never request ninja in its build dependencies as a default behavior.
When scikit-build-core knows a ninja binary wheel exists for a given platform, it's always added as a dependency when a valid one is not found on the system.
Let's allow ninja to depend on ninja only if explicitly allowed (this will speed-up the CI here). In other cases, it's more likely that a request to build ninja would be because of a forced source only build.