chore: modernize build backend and require Python 3.8+ #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/chore/py38
branch
from
2c59819
to
11e8ac8
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/chore/py38
branch
from
11e8ac8
to
e5b37d5
Compare
Signed-off-by: Henry Schreiner <[email protected]>
ast0815
reviewed
Oct 28, 2024
| default_language_version: | ||
| # force all unspecified python hooks to run python3.9 | ||
| # Latest version that can easily be isntalled on Ubuntu 20.04 LTS | ||
| python: python3.9 |
There was a problem hiding this comment.
I needed to add this to ensure that the pre-commit hooks run on my laptop, which is Ubuntu 20.04 LTS. Without this, they try to use the default Python 3.8, and some of the pre-commit checks seem to not support that. Is it harmful in any way to just keep this in for now?
| except ValueError: | ||
| pass | ||
|
|
||
| # Try to interpret file as CSV file | ||
| try: | ||
| data_handle.seek(0) | ||
| _histoprint_csv(data_handle, **kwargs) | ||
| exit(0) | ||
| raise SystemExit(0) |
There was a problem hiding this comment.
Why is this a SystemExit and the other ones return?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some modernization to bring in line with other scikit-hep packages:
exit()is not a Python built-in, but only a site.py thing, sosys.exit()or preferablyraise SystemExit()should be used instead.