-
Notifications
You must be signed in to change notification settings - Fork 127
Open
Labels
Contributors welcome 👋🏻Especially relevant issue/PR for contributors to work on.Especially relevant issue/PR for contributors to work on.Other or internalIf no other grey tag is relevant or if issue from the MAPIE teamIf no other grey tag is relevant or if issue from the MAPIE teamUnprioritized backlogGood ideas yet to be prioritized.Good ideas yet to be prioritized.
Description
Predict params are not passed to the underlying classifiers in some settings:
- In
mapie/estimator/classifier.py
, in the prefit setting, we should pass predict_params. Here is the code to fix:
if self.cv == "prefit":
y_pred_proba = self.single_estimator_.predict_proba(X)
y_pred_proba = self._check_proba_normalized(y_pred_proba)
- In
mapie/conformity_scores/sets/raps.py
, same issue. Fixing this is a bit trickier since theget_conformity_scores
score method currently doesn't have access topredict_params
. Here is the code to fix:
self.y_pred_proba_raps = (
self.predictor.single_estimator_.predict_proba(self.X_raps)
)
- We should clarify in the doctstring that
predict_params
are passed to bothpredict
andpredict_proba
methods. This may be subject to discussion as this implementation choice may not be relevant. - Optional: implement tests to check that the above works
Metadata
Metadata
Assignees
Labels
Contributors welcome 👋🏻Especially relevant issue/PR for contributors to work on.Especially relevant issue/PR for contributors to work on.Other or internalIf no other grey tag is relevant or if issue from the MAPIE teamIf no other grey tag is relevant or if issue from the MAPIE teamUnprioritized backlogGood ideas yet to be prioritized.Good ideas yet to be prioritized.