Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to check if # of dimensions of testing set align with training set in target_encoder #367

Open
hongG1997EQ opened this issue Aug 28, 2022 · 1 comment

Comments

@hongG1997EQ
Copy link

if X.shape[1] != self._dim:
raise ValueError(f'Unexpected input dimension {X.shape[1]}, expected {self._dim}')

For the function _check_transform_inputs(), I do not want it to report error when # of dimensions for testing set don't align with training set. However, the default is it has to align. Considering that the purpose of target encoder is to transform designated columns using target encoders, nothing else, logically we don't have to validate the dimension alignment.

@PaulWestenthanner
Copy link
Collaborator

plase have a look at the dicussion in #355
is this a duplicate of that issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants