-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: scipy-1.14.1-cp312-cp312-macosx_12_0_arm64 wheel rejected by pip check #21436
Comments
Yes, I can see that. I think we might have to go into the wheel and adjust the tag somehow. |
The background to this is that github actions only has M-series build images for macos-14. When we build on that image we have to set MACOS_DEPLOYMENT_TARGET=12.3 because we can't actually get the tools to build as old as 12.0, and This then means that the wheel has 12_3 in it's name, which is invalid as well. We therefore rename the wheel to 12_0. It seems that the tag inside the wheel, in the WHEEL file, also needs amending. We might be able to However, having said that I believe that the wheel is still probably usable, even though it fails |
(It'd be easier if we made a minimum target of 13_0 for macos_arm64). |
@andyfaff, should |
I certainly don't think we're building in the nicest of ways, but I don't think we could've done much else apart from make macos 13 the minimum version. Im not sure that adding an extra tag to packaging solves things, I don't know enough about that. |
I don't have much to add at the moment. If the installed wheel is viable apart from failing |
Agreed, not an emergency, just a thing that would be nice to solve for the next release.
We can't easily go add the missing tags there; only supporting major macOS releases is the current design choice. Improving that to take minor versions into account is discussed at pypa/packaging#578 (content warning: long and complex change).
I think that that would be fine probably. It'd be nicer if that wasn't necessary though. That's perhaps possible:
|
See: - https://git.ligo.org/lscsoft/lalsuite/-/merge_requests/2165#note_1076554 - scipy/scipy#21436 (cherry picked from commit d213687)
Describe your issue.
The wheel installed by
pip install scipy==1.14.1
on an arm64 macos machine running macos 12.7.5 is rejected bypip check
because theTag
metadata isn't recognised:The issue, as I understand it, is that the
Tag
metadata for the wheel doesn't match any of the tags understood by thepackaging
library (vendored insidepip
):i.e. there is no valid
macosx_12_3_arm64
platform.I have no idea whether this is a bug in
pip
/packaging
or an issue with that wheel.Reproducing Code Example
Error message
SciPy/NumPy/Python version and system information
The text was updated successfully, but these errors were encountered: