You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the logging is relatively verbose, which is good, but it would be nice to make it configurable. We always use this logging library for our projects: https://github.com/inconshreveable/log15. For libraries that we create we just set the default Logger to be a "discard" logger. Then the client of the library can decide how they want to configure logging.
This would also let you reduce a lot of repeated code as you can create child loggers that have the same context as their parent.
EDIT: Looks like you've made it configurable with logrus libraries. But it would still be nice to use discrete levels for logging. And personally, I much prefer https://github.com/inconshreveable/log15 to logrus.
Thoughts?
I could work on a PR and you could see what you think.
The text was updated successfully, but these errors were encountered:
Currently the logging is relatively verbose, which is good, but it would be nice to make it configurable. We always use this logging library for our projects: https://github.com/inconshreveable/log15. For libraries that we create we just set the default Logger to be a "discard" logger. Then the client of the library can decide how they want to configure logging.
This would also let you reduce a lot of repeated code as you can create child loggers that have the same context as their parent.
EDIT: Looks like you've made it configurable with logrus libraries. But it would still be nice to use discrete levels for logging. And personally, I much prefer https://github.com/inconshreveable/log15 to logrus.
Thoughts?
I could work on a PR and you could see what you think.
The text was updated successfully, but these errors were encountered: