Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow users to change log levels and configure logging formats #166

Open
ryanwalls opened this issue Apr 13, 2016 · 1 comment

Comments

@ryanwalls
Copy link
Contributor

Currently the logging is relatively verbose, which is good, but it would be nice to make it configurable. We always use this logging library for our projects: https://github.com/inconshreveable/log15. For libraries that we create we just set the default Logger to be a "discard" logger. Then the client of the library can decide how they want to configure logging.

This would also let you reduce a lot of repeated code as you can create child loggers that have the same context as their parent.

EDIT: Looks like you've made it configurable with logrus libraries. But it would still be nice to use discrete levels for logging. And personally, I much prefer https://github.com/inconshreveable/log15 to logrus.

Thoughts?

I could work on a PR and you could see what you think.

@sclasen
Copy link
Owner

sclasen commented Apr 14, 2016

Sounds fine, as long as the log levels dont necessarily appear in all the log lines.

We would also need to have some guidelines for determining what is debug/info/error etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants