Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading secrets from mounted files rather than ENV vars #488

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bdunne
Copy link

@bdunne bdunne commented Jan 26, 2023

This allows keys from kubernetes secrets to be mounted as files to avoid exposing them in the ENV.

This allows keys from kubernetes secrets to be mounted as files to avoid
exposing them in the ENV.
@hhorak
Copy link
Member

hhorak commented Feb 17, 2023

Thanks for contribution, supporting secrets generally looks like a good idea to me and the code is pretty effective. What might not be perfect is to have all secrets available as ENV for the main container process. So, these are my thoughts:

We should likely allow-list variables handled like this. There might be other secrets (private/public keys, certificate) that must be handled differently than putting to the variable and also all the real secretes (passwords, private keys) should not be set for the postmaster process (should be explicitly unset), because the databases itself is so complex, that getting it from the process might be possible by unauthorized users and thus would create a security issue.

@hhorak
Copy link
Member

hhorak commented Feb 17, 2023

Plus we should have a test for this, and include it in the README.md.

@hhorak
Copy link
Member

hhorak commented Feb 17, 2023

I cannot find any guidance what path is recommended for the secrets like this, /run/secrets/postgresql/ does not look wrong, just would like to use something as close as possible to some usual usage (if there is something like this).

@hhorak
Copy link
Member

hhorak commented Feb 17, 2023

@pkubatrh I wonder whether this might be a good learning task for Ondra or Adam (includes some small piece of research).

@fila43
Copy link
Member

fila43 commented Mar 28, 2023

[test]

1 similar comment
@fila43
Copy link
Member

fila43 commented Feb 28, 2024

[test]

Copy link

github-actions bot commented Nov 7, 2024

Pull Request validation

Failed

🔴 Review - Missing review from a member (2 required)

Success

🟢 CI - All checks have passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants