Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

each container in run_change_password_test mounts its own volume #538

Merged
merged 1 commit into from
Dec 7, 2023
Merged

each container in run_change_password_test mounts its own volume #538

merged 1 commit into from
Dec 7, 2023

Conversation

zmiklank
Copy link
Contributor

Could fix: #536

@zmiklank
Copy link
Contributor Author

[test-all]

@zmiklank zmiklank requested a review from phracek November 23, 2023 10:58
phracek
phracek requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point.
It would be nice to add a comment about the reason for it directly to code.

The description is empty. I would like to have something there and not only a link.

@zmiklank zmiklank force-pushed the fix_selinux_warnings branch 2 times, most recently from 1edf42c to 63c78f1 Compare December 4, 2023 14:18
@zmiklank
each container in run_change_password_test mounts its own volume
207981e 
selinux does not allow two containers accesing one mounting directory if
mounted with Z option
@zmiklank zmiklank force-pushed the fix_selinux_warnings branch from 63c78f1 to 207981e Compare December 4, 2023 14:23
@zmiklank
Copy link
Contributor Author

zmiklank commented Dec 4, 2023

It would be nice to add a comment about the reason for it directly to code.
The description is empty. I would like to have something there and not only a link.

@phracek fixed with 207981e

@zmiklank zmiklank requested a review from phracek December 5, 2023 12:50
phracek
phracek approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EVERything LGTM. Thanks for this fix.

[test]

@zmiklank zmiklank merged commit 62a0e88 into sclorg:master Dec 7, 2023
This was referenced Jan 4, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phracek phracek phracek approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

avc: denied raised during the run_change_password_test
2 participants
@zmiklank @phracek