Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add YAML config for imagestreams generator #549

Merged
merged 5 commits into from
Mar 27, 2024
Merged

add YAML config for imagestreams generator #549

merged 5 commits into from
Mar 27, 2024

Conversation

zmiklank
Copy link
Contributor

Depends on: sclorg/ci-scripts#119

@zmiklank zmiklank changed the title add YAML cinfig for imagestreams generator add YAML config for imagestreams generator Jan 23, 2024
@zmiklank zmiklank mentioned this pull request Jan 23, 2024
Merged
@zmiklank zmiklank force-pushed the imagestreams_generator branch 2 times, most recently from 8cfd8ee to aef7d83 Compare January 24, 2024 09:18
phracek
phracek requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to also add GitHub Action that will check if imagestreams were properly generated or not like dist-gen use case. The sort function in the generator would help.

imagestreams/imagestreams.yaml Outdated Show resolved Hide resolved
imagestreams/postgresql-rhel.json Show resolved Hide resolved
@zmiklank zmiklank force-pushed the imagestreams_generator branch from aef7d83 to 9efa860 Compare January 24, 2024 13:37
@zmiklank
Copy link
Contributor Author

It would be good to also add GitHub Action that will check if imagestreams were properly generated or not like dist-gen use case.

I totally agree. I can create some github action for it.

The sort function in the generator would help.

Could you please explain further?

@zmiklank zmiklank force-pushed the imagestreams_generator branch from 9efa860 to f0262f4 Compare January 25, 2024 07:29
@zmiklank zmiklank mentioned this pull request Mar 12, 2024
Merged
@zmiklank zmiklank force-pushed the imagestreams_generator branch from f0262f4 to 9fb3fb2 Compare March 12, 2024 09:53
@zmiklank zmiklank marked this pull request as ready for review March 12, 2024 09:53
@phracek
Copy link
Member

phracek commented Mar 12, 2024

This is blocked by #553 which fixes OpenShift 4 errors.

@phracek
Copy link
Member

phracek commented Mar 13, 2024

Please rebase it against master. Thank you.

@zmiklank zmiklank force-pushed the imagestreams_generator branch from 18821f9 to 10ed0de Compare March 13, 2024 15:23
@phracek
Copy link
Member

phracek commented Mar 14, 2024

[test-openshift]

@zmiklank zmiklank force-pushed the imagestreams_generator branch from 10ed0de to 38c1a4a Compare March 22, 2024 12:54
@zmiklank
Copy link
Contributor Author

@phracek this is rebased on master and ready for review now. Can you please take a look?

phracek
phracek requested changes Mar 25, 2024
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On more issue with the new line at the end of description

imagestreams/postgresql-rhel.json Outdated Show resolved Hide resolved
@zmiklank zmiklank force-pushed the imagestreams_generator branch from 196423e to b3130aa Compare March 26, 2024 14:05
@zmiklank
Copy link
Contributor Author

Depends on: sclorg/ci-scripts#121

@phracek
Copy link
Member

phracek commented Mar 27, 2024

[test-openshift]

@zmiklank zmiklank mentioned this pull request Mar 27, 2024
Closed
14 tasks
@phracek phracek merged commit 3836b38 into sclorg:master Mar 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phracek phracek phracek requested changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmiklank @phracek