Fix error in run_pgaudit_test()
#596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially command `test was missing`, but after it was added test failed and crashed in a way that no more tests were run. This behavior is known issue tracked here in issue sclorg#537 Problem is that `DOCKER_EXTRA_ARGS` variable is set already which it shouldn't be, so the `test` command returns 0, so no `cp` happens and we get the crash. Variable is empty, but apparently do exist as `test -v DOCKER_EXTRA_ARGS` is `TRUE`. Introduced by PR sclorg#399
|
[test] |
phracek
reviewed
Oct 8, 2024
| @@ -934,7 +934,7 @@ run_pgaudit_test() | |||
| # create a dir for config | |||
| config_dir=$(mktemp -d --tmpdir pg-hook-volume.XXXXX) | |||
| add_cleanup_command /bin/rm -rf "$config_dir" | |||
| -v DOCKER_EXTRA_ARGS || cp -r "$test_dir"/examples/pgaudit/* "$config_dir" | |||
| test -n "$DOCKER_EXTRA_ARGS" || cp -r "$test_dir"/examples/pgaudit/* "$config_dir" | |||
There was a problem hiding this comment.
This means if the string is not empty. That's correct. Definition is here https://github.com/sclorg/postgresql-container/blob/master/test/run_test#L41. It means, that if variable is defined, then pgaudit is copied. Am I right?
There was a problem hiding this comment.
This means if the string is not empty.
This is correct
if variable is defined, then pgaudit is copied
Yes as long as the variable is empty, if it's not, it's not copied.
phracek
reviewed
Oct 8, 2024
|
[test] |
Testing Farm results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially command
test was missing, but after it was added test failed and crashed in a way that no more tests were run. This behavior is known issue tracked here in issue #537Problem is that
DOCKER_EXTRA_ARGSvariable is set already which it shouldn't be, so thetestcommand returns 0, so nocphappens and we get the crash.Variable is empty, but apparently do exist as
test -v DOCKER_EXTRA_ARGSisTRUE.Introduced by PR #399
Fixes: #595