This PR migrates DeploymentConfig to Deployment #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phracek
changed the title
See more info here: https://docs.openshift.com/container-platform/4.12/applications/deployments/what-deployments-are.html Since OPenShift 4.14 DeploymentConfigs are deprecated: https://access.redhat.com/articles/7041372 Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
migrate_to_deployment
branch
from
346ad57 to
3bca21a
Compare
|
Fix missing matchLabels selector and trigger for image. [test-openshift] |
phracek
changed the title
Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
migrate_to_deployment
branch
from
c9217c0 to
f87f285
Compare
|
Let's test openshift 4 again. We use master branch in dancer-ex repo again. [test-openshift] |
Signed-off-by: Petr "Stone" Hracek <[email protected]>
|
[test-openshift] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates DeploymentConfig to Deployment.
See more info here:
https://docs.openshift.com/container-platform/4.12/applications/deployments/what-deployments-are.html
Since OPenShift 4.14 DeploymentConfigs are deprecated: https://access.redhat.com/articles/7041372