Add Ruby 3.3 #507
Merged
Add Ruby 3.3 #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing c9s, c8s, rhel9 and rhel8 now. |
|
I have managed to make rails-ex work for Ruby 3.3 as well as with all other releases. Test logs: https://gist.github.com/pvalena/88b5e670e3d8a1bbbc44ee6521708a6f |
|
[test][test-openshift] |
|
I've pushed images for testing: |
|
Can we merge this? Is anything else needed from my side? |
|
Looking at commits you probably didn't follow the flow outlined in the contributing file: https://github.com/sclorg/welcome/blob/master/contribution.md#2-add-sources in that the commit history seems lost on the 3.3 directory. |
|
You're right, sorry, I forgot about that. |
|
BTW there also seem to be some more steps related to the individual tests compared to the last time I touched containers. Actually there is "enable testing" step that should happen as a PR and merged before this one... |
You're right, but I thought I've enabled forgot to check... will fix |
jackorp
reviewed
Feb 5, 2024
|
[test][test-openshift] |
|
Tests failed here: The log from -----------------------------------------------
+ test_connection
++ container_ip
+++ cat /tmp/tmp.2D2lbgSdp4/./tmp.RSX58iohdd.cid
++ docker inspect '--format={{ .NetworkSettings.IPAddress }}' 089a34a5f0baa1c946e4d4333f947dacf822883391c7d77aa79a7d2cc6f40544
+ info 'Testing the HTTP connection (http://10.88.0.8:8080)'
+ echo -e '\n\e[1m[INFO] Testing the HTTP connection (http://10.88.0.8:8080)...\e[0m\n'
�[1m[INFO] Testing the HTTP connection (http://10.88.0.8:8080)...�[0m
+ local max_attempts=10
+ local sleep_time=1
+ local attempt=1
+ local result=1
+ '[' 1 -le 10 ']'
+++ container_ip
++++ cat /tmp/tmp.2D2lbgSdp4/./tmp.RSX58iohdd.cid
+++ docker inspect '--format={{ .NetworkSettings.IPAddress }}' 089a34a5f0baa1c946e4d4333f947dacf822883391c7d77aa79a7d2cc6f40544
++ curl -s -w '%{http_code}' -o /dev/null http://10.88.0.8:8080/
+ response_code=000
+ status=7
+ '[' 7 -eq 0 ']'
+ attempt=2
+ sleep 1
Parsing options from the first comment line is deprecated!
/opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/session/cookie.rb:7: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of rack-2.2.8 to add base64 into its gemspec.
/opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/notifications/fanout.rb:3: warning: mutex_m was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add mutex_m to your Gemfile or gemspec. Also contact author of activesupport-6.1.7.6 to add mutex_m into its gemspec.
/opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/xml_mini.rb:5: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of activesupport-6.1.7.6 to add bigdecimal into its gemspec.
/usr/share/ruby/bundled_gems.rb:74:in `require': Error loading the 'mysql2' Active Record adapter. Missing a gem it depends on? /opt/app-root/src/bundle/ruby/3.3.0/extensions/x86_64-linux/3.3.0/mysql2-0.5.3/mysql2/mysql2.so: undefined symbol: rb_tainted_str_new2 - /opt/app-root/src/bundle/ruby/3.3.0/extensions/x86_64-linux/3.3.0/mysql2-0.5.3/mysql2/mysql2.so (LoadError)
from /usr/share/ruby/bundled_gems.rb:74:in `block (2 levels) in replace_require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:332:in `block in require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:299:in `load_dependency'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:332:in `require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/mysql2-0.5.3/lib/mysql2.rb:36:in `<top (required)>'
from /usr/share/ruby/bundled_gems.rb:74:in `require'
from /usr/share/ruby/bundled_gems.rb:74:in `block (2 levels) in replace_require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:332:in `block in require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:299:in `load_dependency'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:332:in `require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activerecord-6.1.7.6/lib/active_record/connection_adapters/mysql2_adapter.rb:7:in `<top (required)>'
from /usr/share/ruby/bundled_gems.rb:74:in `require'
from /usr/share/ruby/bundled_gems.rb:74:in `block (2 levels) in replace_require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:332:in `block in require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:299:in `load_dependency'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:332:in `require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activerecord-6.1.7.6/lib/active_record/connection_adapters/abstract/connection_pool.rb:1205:in `resolve_pool_config'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activerecord-6.1.7.6/lib/active_record/connection_adapters/abstract/connection_pool.rb:1046:in `establish_connection'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activerecord-6.1.7.6/lib/active_record/connection_handling.rb:52:in `establish_connection'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-activerecord-2.0.22/lib/sinatra/activerecord.rb:64:in `database='
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-2.1.0/lib/sinatra/base.rb:1273:in `set'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-activerecord-2.0.22/lib/sinatra/activerecord.rb:58:in `database_file='
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-2.1.0/lib/sinatra/base.rb:1273:in `set'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-activerecord-2.0.22/lib/sinatra/activerecord.rb:41:in `registered'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-2.1.0/lib/sinatra/base.rb:1455:in `block in register'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-2.1.0/lib/sinatra/base.rb:1453:in `each'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-2.1.0/lib/sinatra/base.rb:1453:in `register'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-2.1.0/lib/sinatra/base.rb:1947:in `register'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-2.1.0/lib/sinatra/base.rb:2008:in `register'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-activerecord-2.0.22/lib/sinatra/activerecord.rb:88:in `<module:Sinatra>'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-activerecord-2.0.22/lib/sinatra/activerecord.rb:12:in `<top (required)>'
from /usr/share/ruby/bundled_gems.rb:74:in `require'
from /usr/share/ruby/bundled_gems.rb:74:in `block (2 levels) in replace_require'
from /opt/app-root/src/config/database.rb:1:in `<top (required)>'
from /opt/app-root/src/app.rb:2:in `require_relative'
from /opt/app-root/src/app.rb:2:in `<top (required)>'
from /usr/share/ruby/bundled_gems.rb:74:in `require'
from /usr/share/ruby/bundled_gems.rb:74:in `block (2 levels) in replace_require'
from /opt/app-root/src/config.ru:2:in `block in <main>'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/builder.rb:116:in `eval'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/builder.rb:116:in `new_from_string'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/builder.rb:105:in `load_file'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/builder.rb:66:in `parse_file'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/server.rb:349:in `build_app_and_options_from_config'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/server.rb:249:in `app'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/server.rb:422:in `wrapped_app'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/server.rb:312:in `block in start'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/server.rb:379:in `handle_profiling'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/server.rb:311:in `start'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/server.rb:168:in `start'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/bin/rackup:5:in `<top (required)>'
from /opt/app-root/src/bundle/ruby/3.3.0/bin/rackup:25:in `load'
from /opt/app-root/src/bundle/ruby/3.3.0/bin/rackup:25:in `<main>'
/usr/share/ruby/bundled_gems.rb:74:in `require': /opt/app-root/src/bundle/ruby/3.3.0/extensions/x86_64-linux/3.3.0/mysql2-0.5.3/mysql2/mysql2.so: undefined symbol: rb_tainted_str_new2 - /opt/app-root/src/bundle/ruby/3.3.0/extensions/x86_64-linux/3.3.0/mysql2-0.5.3/mysql2/mysql2.so (LoadError)
from /usr/share/ruby/bundled_gems.rb:74:in `block (2 levels) in replace_require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:332:in `block in require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:299:in `load_dependency'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:332:in `require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/mysql2-0.5.3/lib/mysql2.rb:36:in `<top (required)>'
from /usr/share/ruby/bundled_gems.rb:74:in `require'
from /usr/share/ruby/bundled_gems.rb:74:in `block (2 levels) in replace_require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:332:in `block in require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:299:in `load_dependency'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:332:in `require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activerecord-6.1.7.6/lib/active_record/connection_adapters/mysql2_adapter.rb:7:in `<top (required)>'
from /usr/share/ruby/bundled_gems.rb:74:in `require'
from /usr/share/ruby/bundled_gems.rb:74:in `block (2 levels) in replace_require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:332:in `block in require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:299:in `load_dependency'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activesupport-6.1.7.6/lib/active_support/dependencies.rb:332:in `require'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activerecord-6.1.7.6/lib/active_record/connection_adapters/abstract/connection_pool.rb:1205:in `resolve_pool_config'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activerecord-6.1.7.6/lib/active_record/connection_adapters/abstract/connection_pool.rb:1046:in `establish_connection'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/activerecord-6.1.7.6/lib/active_record/connection_handling.rb:52:in `establish_connection'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-activerecord-2.0.22/lib/sinatra/activerecord.rb:64:in `database='
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-2.1.0/lib/sinatra/base.rb:1273:in `set'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-activerecord-2.0.22/lib/sinatra/activerecord.rb:58:in `database_file='
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-2.1.0/lib/sinatra/base.rb:1273:in `set'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-activerecord-2.0.22/lib/sinatra/activerecord.rb:41:in `registered'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-2.1.0/lib/sinatra/base.rb:1455:in `block in register'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-2.1.0/lib/sinatra/base.rb:1453:in `each'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-2.1.0/lib/sinatra/base.rb:1453:in `register'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-2.1.0/lib/sinatra/base.rb:1947:in `register'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-2.1.0/lib/sinatra/base.rb:2008:in `register'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-activerecord-2.0.22/lib/sinatra/activerecord.rb:88:in `<module:Sinatra>'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/sinatra-activerecord-2.0.22/lib/sinatra/activerecord.rb:12:in `<top (required)>'
from /usr/share/ruby/bundled_gems.rb:74:in `require'
from /usr/share/ruby/bundled_gems.rb:74:in `block (2 levels) in replace_require'
from /opt/app-root/src/config/database.rb:1:in `<top (required)>'
from /opt/app-root/src/app.rb:2:in `require_relative'
from /opt/app-root/src/app.rb:2:in `<top (required)>'
from /usr/share/ruby/bundled_gems.rb:74:in `require'
from /usr/share/ruby/bundled_gems.rb:74:in `block (2 levels) in replace_require'
from /opt/app-root/src/config.ru:2:in `block in <main>'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/builder.rb:116:in `eval'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/builder.rb:116:in `new_from_string'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/builder.rb:105:in `load_file'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/builder.rb:66:in `parse_file'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/server.rb:349:in `build_app_and_options_from_config'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/server.rb:249:in `app'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/server.rb:422:in `wrapped_app'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/server.rb:312:in `block in start'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/server.rb:379:in `handle_profiling'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/server.rb:311:in `start'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/lib/rack/server.rb:168:in `start'
from /opt/app-root/src/bundle/ruby/3.3.0/gems/rack-2.2.8/bin/rackup:5:in `<top (required)>'
from /opt/app-root/src/bundle/ruby/3.3.0/bin/rackup:25:in `load'
from /opt/app-root/src/bundle/ruby/3.3.0/bin/rackup:25:in `<main>'
+ '[' 2 -le 10 ']' |
|
If I am reading the logs correctly the mysql2 failure is a bit problematic, AFAICT the problem is coming from this repo: https://github.com/openshift/ruby-hello-world which is using the mysql2 gem. We should be, in theory, able to just upgrade that gem. skimmed the logs, also saw some postgresql failures: Both, the mysql2 and PG DB connectors install failure are related to C API methods having been removed from Ruby. They are used by these older gems and Ruby 3.3. As we want to still test RHEL 7, now comes the point to branch out the rails-ex used in tests to install this there is sclorg/rails-ex#169 made to address the PG failure. I am crossing my fingers that mysql2 update will just work. |
|
Made a PR for the mysql2 failure: openshift/ruby-hello-world#146 |
|
#518 Made PR to use the new rails-ex branch |
|
[test][test-openshift] |
Biggest suspect is currently newer bundler v2.5.3 distributed with Ruby 3.3 that is trying to rewrite Gemfile.lock for some reason. Of course that will fail since everything in the directory is owned by root. If I use $ gem install --bindir=/opt/app-root/src/other_bin bundler --version 2.5.3
$ export PATH="$PATH:/opt/app-root/src/other_bin"(specifying bindir and appending PATH is required since there is already one bindir on Change happened between bundler 2.4.22 and 2.5.0. This might not be an easy or even desired fix for Ruby... 2.5 openshift tests: The bigger problem is the following, probably something with the rails-ex app assemble script. I'll inspect the script used to see what's the problem. |
|
The test_from_dockerfile on Ruby 3.3 is broken because of: rubygems/rubygems#7220 , it now basically does So with that in mind, when we
Or IMHO even better, one of following fixes it better because I'd say the Dockerfile is incorrect: 1. ADD with chowndiff --git a/examples/from-dockerfile/Dockerfile b/examples/from-dockerfile/Dockerfile
index 3ef8baa..b4d3db9 100644
--- a/examples/from-dockerfile/Dockerfile
+++ b/examples/from-dockerfile/Dockerfile
@@ -1,6 +1,6 @@
FROM ubi8/ruby-27
-ADD app-src ./
+ADD --chown=default:root app-src ./
RUN bundle install --path ./bundle2. chown the dirdiff --git a/examples/from-dockerfile/Dockerfile b/examples/from-dockerfile/Dockerfile
index 3ef8baa..4eeebf2 100644
--- a/examples/from-dockerfile/Dockerfile
+++ b/examples/from-dockerfile/Dockerfile
@@ -1,6 +1,9 @@
FROM ubi8/ruby-27
+USER 0
ADD app-src ./
+RUN chown -R default:root ./
+USER default
RUN bundle install --path ./bundle
3. Just be rootdiff --git a/examples/from-dockerfile/Dockerfile b/examples/from-dockerfile/Dockerfile
index 3ef8baa..01f61bf 100644
--- a/examples/from-dockerfile/Dockerfile
+++ b/examples/from-dockerfile/Dockerfile
@@ -1,5 +1,6 @@
FROM ubi8/ruby-27
+USER 0
ADD app-src ./
RUN bundle install --path ./bundleAll 3 approaches were tested locally, it no longer fails with any of them. ... |
|
The 2.5 might be failing because it is taking 3.3 rails-ex branch that had updated the assemble file. I messed up the condition... |
This was referenced Feb 27, 2024
(3 step/commit workflow to preserve history)
(3 step/commit workflow to preserve history)
(3 step/commit workflow to preserve history)
|
[test-all] |
|
Ruby 3.0 Docker test failed because RHEL 7 does not have new enough docker that has |
zmiklank
reviewed
Mar 27, 2024
| ENV NAME=ruby \ | ||
| RUBY_VERSION=3.3 \ | ||
| RUBY_SHORT_VER=33 \ | ||
| VERSION=0 |
There was a problem hiding this comment.
Can you please set the VERSION to empty string?
To fix this issue:
#530
|
[test] |
|
RHEL8 and RHEL9 3.3 versions failed for this reason: @jackorp PTAL |
|
if I am reading it correctly, there is no running container, so tests expecting it fail. The problem is visible more up, when testing the actual app: I think the curl triggers chain of library loading until we get to the gem's extension and fail because the The following is the culprit: The API was removed in Ruby 3.3, so loading the binary extension of the gem that is expecting it will fail. The source seems to be from git repo: And from logs we can see path: The for which there is already a PR that bumps the gem version that no longer fails due to the removed APIs: openshift/ruby-hello-world#146 So in this case we are depending on that PR's content to unblock that part of CI as well. |
Signed-off-by: Petr "Stone" Hracek <[email protected]>
|
OpenShift part was merged. Let's try one more round [test] |
zmiklank
reviewed
May 14, 2024
| @@ -118,7 +118,7 @@ scl_usage() { | |||
| } | |||
|
|
|||
| function test_scl_usage() { | |||
| scl_usage "ruby --version" "ruby ${RUBY_VERSION}." | |||
| scl_usage "ruby --version" "ruby ${VERSION}." | |||
There was a problem hiding this comment.
$VERSION should be se to empty string. Not sure this test does what it should have.
There was a problem hiding this comment.
The test tests if ruby version is the same as tests. Like we do in the rest containers.
Nevertless, RUBY_VERSION is specified in container and not in host system where the test is running.
As examples see:
https://github.com/sclorg/s2i-php-container/blob/master/test/run#L186
https://github.com/sclorg/s2i-nodejs-container/blob/master/test/test-lib-nodejs.sh#L250
|
Yay, new error (I didn't meet it before with the app...) Though this one seems strange. It is looking for |
|
The file that is under Sinatra upstream fixed it in: sinatra/sinatra#1973 Ruby 3.3 caused it most probably in: ruby/ruby@214f6d6 There is some smartistic with regards to where the app.rb is located in sinatra code. Here we have an actual alternative. We can add something akin to |
Ah :( But it's inevitable in the end I guess....
That fix would be in the example app, right? Do you think it's a stable solution? Can you please look into that? |
Yes, we could even inject the line ourselves for Ruby 2.5 if the need arises.
It should work OK even for longer time. (Edit note: currently tested versions of sinatra 3.2.0 and 4.0.0. Completely OK and working with the option). |
|
@phracek / @zmiklank The PR fixing the issue via setting the option openshift/ruby-hello-world#147 was merged, please re-test |
|
[test-all] |
|
Testing Farm - RHEL9 - 3.3 and Testing Farm - RHEL8 - 3.3 is green 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing, I'm using Ruby from my COPR, as it's built for c9s/c8s etc.
You can find the changes here: https://github.com/pvalena/s2i-ruby-container/tree/3.3-experimental
And I've also pushed the built images for testing: #507 (comment)