Add testing templates

[phracek]

Add testing templates.

Templates were not tested. This pull request allows it.

[phracek]

[test-openshift]

[phracek]

Templates added. Tests are executed on rails.json template with no database.

[test-openshift]

[phracek]

Tested on rails-ex PR sclorg/rails-ex#166

[phracek]

[test-all]

[phracek]

[test-openshift]

[phracek]

[test]

[jackorp]

@phracek Hmm, looking at this, we are now testing the app with no database?

However it seems you added some changes that import the postgresql image now, so it should work now, is that correct?

So are we expecting all 3 currently present templates (rails.json, rails-postgresql.json, rails-postgresql-persistent.json) to show up in the tests and be tested? I can only see rails.json AFAICT.

What do we expect to be tested then should be answered and I think all else is good to be merged, since the tests are green and the logs look OK from a short glance.

[phracek]

@phracek Hmm, looking at this, we are now testing the app with no database?

However it seems you added some changes that import the postgresql image now, so it should work now, is that correct?

So are we expecting all 3 currently present templates (rails.json, rails-postgresql.json, rails-postgresql-persistent.json) to show up in the tests and be tested? I can only see rails.json AFAICT.

What do we expect to be tested then should be answered and I think all else is good to be merged, since the tests are green and the logs look OK from a short glance.

@jackorp Thanks for this question. As you can see, the templates were not tested at all and this pull request only tests rails.json. In the future as soon as rails-postgresql-persistent.json works, I would like to add. I have to find out a way where to add a variable RAILS_LOG_TO_STDOUT="something".

[jackorp]

I have to find out a way where to add a variable RAILS_LOG_TO_STDOUT="something".

diff --git a/examples/rails-postgresql-persistent.json b/examples/rails-postgresql-persistent.json
index 74a5d26..20547ee 100644
--- a/examples/rails-postgresql-persistent.json
+++ b/examples/rails-postgresql-persistent.json
@@ -279,6 +279,10 @@
                   {
                     "name": "RAILS_ENV",
                     "value": "${RAILS_ENV}"
+                  },
+                  {
+                    "name": "RAILS_LOG_TO_STDOUT",
+                    "value": "something"
                   }
                 ],
                 "resources": {
diff --git a/examples/rails-postgresql.json b/examples/rails-postgresql.json
index b482260..2f280a7 100644
--- a/examples/rails-postgresql.json
+++ b/examples/rails-postgresql.json
@@ -279,6 +279,10 @@
                   {
                     "name": "RAILS_ENV",
                     "value": "${RAILS_ENV}"
+                  },
+                  {
+                    "name": "RAILS_LOG_TO_STDOUT",
+                    "value": "something"
                   }
                 ],
                 "resources": {
diff --git a/examples/rails.json b/examples/rails.json
index a29a439..e4383b6 100644
--- a/examples/rails.json
+++ b/examples/rails.json
@@ -182,6 +182,10 @@
                   {
                     "name": "RAILS_ENV",
                     "value": "${RAILS_ENV}"
+                  },
+                  {
+                    "name": "RAILS_LOG_TO_STDOUT",
+                    "value": "something"
                   }
                 ],
                 "resources": {

This should work.
Since those deployments define RAILS_ENV, it should be the correct container.

[phracek]

@jackorp It looks like everything is passing. We can merge it. WDYT?

[phracek]

Sorry, I have missed your comment #508 (comment). What about to create an issue to rails-postgresql-persistent.json and this merge it?

[jackorp]

LGTM.

[jackorp]

What about to create an issue to rails-postgresql-persistent.json and this merge it?

Yeah, sure, sounds good. Let's address it separately.

Btw AFAICT I don't have write access to the repo so I can't give you the correct approval (since it requires approval from a write capable member)