Chown the directories added into container in test_from_dockerfile.

[jackorp]

Since bundler v2.5.0, if the frozen option is not specified via CLI or config, bundler will 'touch' the Gemfile.lock to update timestamps. This will fail in test_from_dockerfile since the app-src is added into the container with ownership of root:root.

Ideally, we expect the directory is writeable, so adjust ownership via the Containerfile ADD --chown=: instruction.

Commit in bundler that introduced this behavior:
rubygems/rubygems@b08f2f1

Fixes for 3.3 test_from_dockerfile tests in #507 .

There are other alternatives, such as adding the --frozen, however supplying that is deprecated, so there would need to be an additional step that would use set and then we are depending on the behavior of bundler, which I personally don't like. I find it better to just own the directory. Other alternative is just chowning Gemfile.lock and leave the rest of the directory be.

[zmiklank]

I am not sure why is the test run for every image if it only tests ubi8/ruby-27.
Am I missing something?

Otherwise LGTM. I would also consider bumping the FROM image, as ubi8/ruby-27 is not supported anymore

[jackorp]

Am I missing something?

There be magic (and maybe dragons).

I checked the logs to not have to trace function in the test sources. Since we have -x we can see the following that it's doing in the following test_from_dockerfile excerpt from RHEL Ruby 3.3 Dockerfile test:

<...cut...>
+ sed -i -e 's|^FROM.*$|FROM ubi9/ruby-33:1|' Dockerfile
+ echo 'Using this Dockerfile:'
Using this Dockerfile:
+ cat Dockerfile
FROM ubi9/ruby-33:1

ADD app-src ./

RUN bundle install --path ./bundle

CMD exec bundle exec "rackup -P /tmp/rack.pid --host 0.0.0.0 --port 8080"
<...cut...>

So actually, the tests themselves change with sed the FROM without a care what was there before. Which makes sense, the tests create an image for themselves that we want to use to actually test the content of a PR.

This looks like the correct source: https://github.com/sclorg/container-common-scripts/blob/1e82b93382d056dd17b90b8e0e637e5bfb9cbb88/test-lib.sh#L1241

I would also consider bumping the FROM image, as ubi8/ruby-27 is not supported anymore

I don't think there is any danger to that, at least for our tests. Therefore I have done so and updated both Dockerfiles in the directory to use ubi8 Ruby 3.1

[zmiklank]

There be magic (and maybe dragons).

Indeed! Thanks for the analysis.