refactor: 💡 remove unnecessary codes and comments

Author: scnsh

README.md

@@ -96,7 +96,7 @@ uv sync
 3. **AIチャットやツールパネルからAPIを呼び出し**
 
 - AIチャット上で `user_get_info` や `posts_get_list` などのMCPツールを呼び出すことで、esa.io APIと連携した操作が可能です。
-- `mcp-esa-server  を使って記事の作成をお願いします` などとチャット上で書き込むことで利用できます。
+- `mcp-esa-serverを使って記事の作成をお願いします` などとチャット上で書き込むことで利用できます。
 
 ## ライセンス (License)
 
@@ -107,7 +107,7 @@ uv sync
 
 このプロジェクトの一部では、以下のMIT Licenseで公開されているコードを参照しています。
 
-- **[参照元プロジェクト名]**
+- **esa-mcp-server**
   - GitHubリポジトリ: [https://github.com/masseater/esa-mcp-server]
   - ライセンス: MIT License
 

docs/mcp_esa_development_summary.md

@@ -6,9 +6,7 @@
 
 ## サーバー設計・技術スタック
 
-- **FastAPI**: Webフレームワーク
 - **FastMCP**: MCPプロトコル実装
-- **aiohttp**: 非同期HTTPクライアント
 - **pytest/ruff**: テスト・フォーマット
 
 ## 主要機能

docs/mcp_esa_server_usage.md

@@ -34,7 +34,7 @@ ESA_TEAM_NAME=your_team_name
 - **引数:** `post_number`（記事番号）
 - **戻り値:** 記事詳細情報を含む辞書（例: `{ "post": {...} }`）
 
-### posts_create(name: str, body_md: str, tags: list[str] | None = None, category: str | None = None, wip: bool | None = True, message: str | None = None)
+### posts_create(name: str, body_md: str, tags: list[str] = [], category: str = "", wip: bool = True, message: str = "")
 - **説明:** 新しい記事を作成します。
 - **引数:** `name`, `body_md`, `tags`, `category`, `wip`, `message`
 - **戻り値:** 作成された記事の情報（例: `{ "post": {...} }`）

esa_client.py

@@ -122,11 +122,6 @@ def delete_post(self, post_number: int):
     try:
         client = EsaClient()
         logger.info(f"EsaClient initialized for team: {client.team_name}")
-        # Add a simple test request here later if needed
-        print("Attempting to get user info...")
-        user_info = client.get_user()
-        print("Successfully retrieved user info:")
-        print(user_info)
     except ValueError as e:
         logger.error(f"Initialization failed: {e}")
     except requests.exceptions.RequestException as e:

main.py

@@ -3,14 +3,9 @@
 from typing import Annotated, Any
 
 from dotenv import load_dotenv
-
-# Remove FastAPI and HTTPException imports as they are no longer directly used
-# from fastapi import FastAPI, HTTPException
 from mcp.server.fastmcp import FastMCP
 from pydantic import Field
 
-# Use direct import as files are now in the same directory
-# from src.esa_client import EsaClient
 from esa_client import EsaClient
 
 # Load environment variables from .env file
@@ -20,17 +15,13 @@
 logging.basicConfig(level=logging.INFO)
 logger = logging.getLogger(__name__)
 
-# Remove FastAPI app initialization
-# app = FastAPI()
-
 # Create MCP instance
 mcp = FastMCP("esa-mcp-server")
 
 # Get environment variables
 esa_token = os.getenv("ESA_TOKEN")
 esa_team_name = os.getenv("ESA_TEAM_NAME")
 
-# 追加: 環境変数の値をログに出力
 logger.info("Attempting to initialize EsaClient.")
 logger.info(f"ESA_TOKEN from env: {esa_token}")
 logger.info(f"ESA_TEAM_NAME from env: {esa_team_name}")
@@ -41,8 +32,6 @@
     esa_client = None
 else:
     try:
-        # Initialize EsaClient without arguments, let it read env vars internally
-        # esa_client = EsaClient(api_token=esa_token, team_name=esa_team_name)
         esa_client = EsaClient()
         logger.info("EsaClient initialized successfully.")
     except ValueError as e:  # Catch potential ValueError from EsaClient init
@@ -143,32 +132,27 @@ def posts_create(
     """
     if esa_client is None:
         logger.error("EsaClient is not initialized. Cannot create post.")
-        raise RuntimeError("EsaClient not initialized")  # Changed from HTTPException
+        raise RuntimeError("EsaClient not initialized")
     try:
         logger.info(f"Creating post with name: {name}")
 
-        # MODIFIED SECTION: Handle empty string category as None
-        # This ensures that if category is an empty string (default or explicitly passed),
-        # it's treated as 'no category' and will be removed from the payload if None.
-        effective_category = category if category else None
-
         payload = {
             "name": name,
             "body_md": body_md,
             "tags": tags or [],
-            "category": effective_category,
+            "category": category,
             "wip": wip,
             "message": message,
         }
         # Remove None values from payload
         payload = {k: v for k, v in payload.items() if v is not None}
 
-        new_post = esa_client.create_post(payload=payload)  # Removed await
+        new_post = esa_client.create_post(payload=payload)
         logger.info(f"Successfully created post: {new_post.get('url')}")
         return new_post
     except Exception as e:
         logger.error(f"Error creating post: {e}", exc_info=True)
-        raise RuntimeError(f"Error creating post: {e}") from e  # Changed from HTTPException
+        raise RuntimeError(f"Error creating post: {e}") from e
 
 
 @mcp.tool()
@@ -194,7 +178,7 @@ def posts_update(
     """
     if esa_client is None:
         logger.error("EsaClient is not initialized. Cannot update post.")
-        raise RuntimeError("EsaClient not initialized")  # Changed from HTTPException
+        raise RuntimeError("EsaClient not initialized")
     try:
         logger.info(f"Updating post number: {post_number}")
         payload = {
@@ -211,15 +195,14 @@ def posts_update(
         if not payload:
             logger.warning(f"No update parameters provided for post {post_number}.")
             # Consider returning current post details or raising a more specific error
-            # For now, returning a message indicating no action was taken.
             return {"message": f"No update parameters provided for post {post_number}. Nothing changed."}
 
         updated_post = esa_client.update_post(post_number=post_number, payload=payload)
         logger.info(f"Successfully updated post: {updated_post.get('url')}")
         return updated_post
     except Exception as e:
         logger.error(f"Error updating post {post_number}: {e}", exc_info=True)
-        raise RuntimeError(f"Error updating post: {e}") from e  # Changed from HTTPException
+        raise RuntimeError(f"Error updating post: {e}") from e
 
 
 @mcp.tool()
@@ -231,34 +214,18 @@ def posts_delete(post_number: int) -> dict[str, Any]:
     """
     if esa_client is None:
         logger.error("EsaClient is not initialized. Cannot delete post.")
-        raise RuntimeError("EsaClient not initialized")  # Changed from HTTPException
+        raise RuntimeError("EsaClient not initialized")
     try:
-        logger.info(f"Deleting post number: {post_number}")
-        esa_client.delete_post(post_number)  # Removed await
+        esa_client.delete_post(post_number)
         logger.info(f"Successfully deleted post {post_number}.")
         # Return empty dict upon successful deletion as per esa.io API
-        # (204 No Content)
         return {}
     except Exception as e:
         logger.error(f"Error deleting post {post_number}: {e}", exc_info=True)
-        raise RuntimeError(f"Error deleting post: {e}") from e  # Changed from HTTPException
-
-
-# Mount MCP router using sse_app
-# app.include_router(mcp.router)
-# app.mount("/mcp", app=mcp.sse_app())
-# @app.get("/")
-# async def root():
-#    return {"message": "MCP Server for esa.io is running"}
-
+        raise RuntimeError(f"Error deleting post: {e}") from e
 
-# TODO: Add MCP tools based on EsaClient methods
-# TODO: Add error handling for EsaClient initialization failures
 
 # Use mcp.run() to start the server when script is executed directly
 if __name__ == "__main__":
-    # Remove uvicorn import and run
-    # import uvicorn
-    # uvicorn.run(app, host="0.0.0.0", port=8000)
     logger.info("Starting MCP server...")
     mcp.run()

pyproject.toml

@@ -6,7 +6,6 @@ authors = [
     {name = "Naoki Numaguchi", email = "[email protected]"},
 ]
 dependencies = [
-    # "fastapi", # Removed fastapi as it's no longer directly used
     "requests",
     "python-dotenv",
     "mcp[cli]>=1.7.1",