Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean output if json parameter is not set #378

Open
gavignon opened this issue Nov 2, 2022 · 4 comments · May be fixed by #415
Open

Clean output if json parameter is not set #378

gavignon opened this issue Nov 2, 2022 · 4 comments · May be fixed by #415
Assignees
@scolladon
Labels
enhancement New feature or request

Comments

@gavignon
Copy link
Contributor

gavignon commented Nov 2, 2022

Clean output if json parameter is not set

Remove json output if --json parameter is not set, use spinner instead.

What is the current result ?

sfdx sgd:source:delta -s force-app -f <FROM> -t <TO> -o <OUTPUT>
Result:
{ "error": null, "output": "<OUTPUT>", "success": true, "warnings": [] }

What are the expected results ?

  1. Without JSON parameter:
    sfdx sgd:source:delta -s force-app -f <FROM> -t <TO> -o <OUTPUT>
    Result:
    Generating delta...done or nothing

  2. With JSON parameter
    sfdx sgd:source:delta -s force-app -f <FROM> -t <TO> -o <OUTPUT> --json
    Result:
    { "error": null, "output": "<OUTPUT>", "success": true, "warnings": [] }
@gavignon gavignon added the enhancement New feature or request label Nov 2, 2022
@scolladon
Copy link
Owner

scolladon commented Nov 2, 2022 •
edited
Loading

Thanks @gavignon !

We'll look into it, it may introduce breaking changes but it will be closer to the standard behavior

@mehdicherf
Copy link
Collaborator

mehdicherf commented Nov 3, 2022 •
edited
Loading

I agree that we were to launch the plugin today we should have implemented the behaviour described by @gavignon .

But since SGD is already heavily used, I have mixed feeling about introducing a breaking change.

@gavignon are you facing an issue that would be solved by this change?
Or did you log this issue simply to recommend that SGD should follow the "usual" behaviour of the other sfdx commands?

@gavignon
Copy link
Contributor Author

gavignon commented Nov 3, 2022

Thanks for the quick feedback @mehdisfdc @scolladon !

This is not a show stopper, I would like this enhancement to increase the readability in the jobs, as this output is not needed.
To avoid introducing breaking changes, maybe this can be done through a new parameter "--silent" ?

@mehdicherf
Copy link
Collaborator

I like the idea of a new --silent flag

@gavignon gavignon linked a pull request Jan 9, 2023 that will close this issue
Open
@scolladon scolladon mentioned this issue Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scolladon scolladon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: silent flag parameter gavignon/sfdx-git-delta
3 participants
@scolladon @gavignon @mehdicherf