Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the @variable.member and @lsp.type.property treesitter highlight groups as defaults #121

Closed
231tr0n opened this issue Aug 12, 2024 · 1 comment
Labels
question Further information is requested

Comments

@231tr0n
Copy link

231tr0n commented Aug 12, 2024

Question or Suggestion

Hi scottmckendry!
I think you addressed these highlight groups in this issue #84 (comment).
I just wanted to know if these two highlight groups can be added as defaults for treesitter instead of me overriding it since they seem to play an import role in languages like lua and javascript.
These are the below treesitter highlights.

overrides = function(colors)
	return {
		["@variable.member"] = { fg = colors.pink },
		["@lsp.type.property"] = { fg = colors.pink },
	}
end,

This changes a lot and the colorscheme looks a lot better with this highlights for languages like lua and js
image
image

@231tr0n 231tr0n added the question Further information is requested label Aug 12, 2024
@scottmckendry
Copy link
Owner

It's definitely a change that I could make. However, what seems like important syntax to one person may be entirely undesirable to another.

If I make this change so you can remove your overrides, someone else who prefers the current default (like me 😉) will need to do the opposite.

Hopefully, this makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants