Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overrides is not called #134

Closed
OliverGuy opened this issue Sep 4, 2024 · 3 comments
Closed

overrides is not called #134

OliverGuy opened this issue Sep 4, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@OliverGuy
Copy link

OliverGuy commented Sep 4, 2024

Description

Greetings, love the theme!
Just trying to switch color around to get closer to my old vscode setup 😄
When using overrides(colors) in the setup options, the function does not seem to get called.

Neovim version?

0.10.1

What should happen?

Expected functions to be yellow, or at least the debug message 'Overriding!' to be printed.

What happened instead?

Functions are still blue, and no message was printed.

Your configuration

{
   'scottmckendry/cyberdream.nvim',
    priority = 1000,
    lazy = false,
    init = function()
      vim.g.colors_name = 'cyberdream'
      vim.cmd.colorscheme 'cyberdream'
    end,
    opts = {
      transparent = false,
      borderless_telescope = false,
      overrides = function(colors)

        print 'Overriding!'

        local highlights = {
          Function = { fg = colors.yellow },
        }
        return highlights
      end,
    },
}
@OliverGuy OliverGuy added the bug Something isn't working label Sep 4, 2024
@scottmckendry
Copy link
Owner

Hello @OliverGuy!

Glad to hear you're enjoying cyberdream 🙂

I'd recommend double-checking you're overriding the correct group. You can do this by moving your cursor over the syntax you want to check and running :Inspect.

@scottmckendry
Copy link
Owner

Oh, never mind! I think i've spotted the problem.

overrides is a child property of theme e.g.

opts = { theme = { overrides = [your override function] } }

That should fix it, pretty sure 👍🏻

@scottmckendry scottmckendry added the waiting for op This issue is waiting for a response from the original poster label Sep 4, 2024
@OliverGuy
Copy link
Author

That did it, much appreciated ! 🙏

@github-actions github-actions bot removed the waiting for op This issue is waiting for a response from the original poster label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants