Syntax highlighting

[gldtn]

Question or Suggestion

I just noticed while I was playing with italics that my syntax highlighting is different from the original cyberdream for some reason:

Any idea what might be overriding? Or what I can check?

Thanks!

[scottmckendry]

Hey @gldtn!

Can you be more specific about what is wrong? Nothing is jumping out at me from your screenshot.

[gldtn]

Hey @gldtn!

Can you be more specific about what is wrong? Nothing is jumping out at me from your screenshot.

For example, the scopes(words in this case): local, require, @param, if, then, elseif, for, in, do, nvim_set_hl are all in white on my end, vs the screenshot from the readme you provided which is in orange.

Here I tried replicating it on this shot:

vs yours:

[scottmckendry]

ah! I see. are you using treesitter and have the lua parser installed?

[gldtn]

Hmm, seems like there was a couple of things affecting, first my lame attempt to get .blade.php files to be parsed correctly:

After commenting this out, treesitter started parsing correctly..

-- -- FIXME: this is a hack to add blade support
		-- local parser_config = require("nvim-treesitter.parsers").get_parser_configs()
		--
		-- ---@class ParserConfig
		-- parser_config.blade = {
		-- 	install_info = {
		-- 		url = "https://github.com/EmranMR/tree-sitter-blade",
		-- 		files = { "src/parser.c" },
		-- 		branch = "main",
		-- 	},
		-- 	filetype = "blade",
		-- }
		--
		-- vim.filetype.add({
		-- 	pattern = {
		-- 		[".*%.blade%.php"] = "blade",
		-- 	},
		-- })

Colors were also different due to me playing with italics:
cyberdream.lua

overrides = function(colours)
					return {
						-- italics
						Keyword = { italic = true },
						-- Constant = { italic = true },
						Function = { italic = true },
						Identifier = { italic = true },
						-- non-italics
						Unit = { italic = false },
						Error = { italic = false },
						Number = { italic = false },
					}
				end,

What is the proper way to add more italics to the theme without overriding the original colors?

[scottmckendry]

The overrides function is intended to override the highlight group entirely, so you'd need to give it a colour otherwise it will just default to the value of fg.

So in this case, your config should look like this:

overrides = function(colours)
    return {
        -- italics
        Keyword = { fg = colours.orange, italic = true},
        Function = { fg = colours.blue, italic = true },
        -- and so on ...
    }
end,

That would be the way to do it inside the cyberdream config. However, a more simple approach in your case could be to set the italic property after cyberdream.nvim has already been set up. In that case, the following example should work:

return {
    {
        "scottmckendry/cyberdream.nvim",
        dev = true,
        lazy = false,
        priority = 1000,
        config = function()
            require("cyberdream").setup({})
            vim.cmd("colorscheme cyberdream")

            -- define italic groups
            local italic_groups = {
                "Keyword",
                "Function",
            }

            -- must appear AFTER the "colorscheme cyberdream" command
            for _, group in ipairs(italic_groups) do
                vim.cmd("hi " .. group .. " gui=italic cterm=italic")
            end
        end,
    },
}

[gldtn]

I do like that second approach, but that seems like it reverts the colors to the default Treesitter/LSP highlights. At least from the quick test I did here. So might have to go through :hi and match the ones I want to change. I ran into this issue here and being using fzf to discover all the highlights colors you set, thanks for the help as always!