Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngtemplate-loader broken by [email protected] #182

Closed
scottohara opened this issue May 27, 2020 · 0 comments
Closed

ngtemplate-loader broken by [email protected] #182

scottohara opened this issue May 27, 2020 · 0 comments

Comments

@scottohara
Copy link
Owner

scottohara commented May 27, 2020

Currently we're pinned to [email protected] while waiting for this to be merged/released:

WearyMonkey/ngtemplate-loader#86

When we eventually can upgrade to [email protected], the config needs to change to this:

{
  loader: "html-loader",
  options: {
    attributes: {
      list: [
        ...,
        { attribute: "typeahead-template-url", type: "src" }
      ]
    },
    minimize: false
  }
}

When testing this change, check whether minimize: false is needed (its now true by default for production mode in 1.x, but its not clear whether minimize will work with partial templates)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant