-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response signature validation: error on version 0.9 #57
Comments
Same problem here. The new version doesn't work at all. |
Is this no longer developed? |
I think this is more of an issues with the Sample app in the playstore? If so I had to change the way the Google Cloud API was configured to lock in down further as a previous API key was compromised. I think this is the reason this API calls is now failing. Even if that isn't the case on reviewing the decision to add this validation to the library, I feel it's fairly pointless given this SafetyNet response is validated on device and this could be hooked/tampered with. In #62 and version 0.10.0 this will be removed. |
In my opinion it still would be nice to have the validation in the library to be able to test if the SafetyNet API is working correctly. |
@ale5000-git thanks for voicing that. This removal could just be temporary potentially someone could raise a PR with it back in. There's some offline validation we could add as mentioned here. This feels more inline with what this library is, app based safetynet check (with all the cavets that previously mentioned about app based being not the most ideal or secure) Also just to confirm the library would still call the attest, decode the JWT response and validate the content matches the app. It just wouldn't be doing the API call to validate that the attest response actually came from Google. |
With the version 0.9 I get:
I was passing correctly in the previous version and it still passing in another app called "SafetyNet Test".
The text was updated successfully, but these errors were encountered: