Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to ppc64le. Disable pypy as this is not supported #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gururajrkatti
Copy link

This PR adds CI support for the IBM Power Little Endian (ppc64le) architecture. The idea is to ensure that the builds on this architecture are continuously tested along with the Intel builds (amd64) as this is part of the ubuntu distro on that architecture as well and detecting (and fixing) any issues
or failures early would help to ensure that we are always up to date.

@gururajrkatti
Copy link
Author

Hi just wanted to check if you got a chance to look into this.

@Ede123
Copy link
Member

Ede123 commented Feb 21, 2021

Thanks for this and sorry for slow response!

Can you clarify a bit how testing on ppc64le will profit Scour? Naively I'd assume Python to work the same irregardless of the target architecture (unless there's a bug in Python, but I hope that they in turn have suitable CI to catch this precise issue).

If there's a justified risk of some scour-specific functionality to depend heavily on target architecture I'd be happy do accept this, but if it's just "testing for testing's sake" I'd rather avoid the added complexity.

@gururajrkatti
Copy link
Author

Hi @Ede123 Thanks for the response. I understand that pure python package should work fine on other platforms. However based on our experience earlier, even python packages can fail on other platforms because of an indirect dependency on native code or libraries via other python dependencies. Hence this is proposed to catch any such issues early. Tagging @gerrith3 for any additional info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants