-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solves #304 #305
Open
JoKalliauer
wants to merge
1
commit into
scour-project:master
Choose a base branch
from
JoKalliauer:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
solves #304 #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github instead of gitlab
mackenly
approved these changes
Mar 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ryandesign
reviewed
Jun 6, 2023
@@ -16,7 +16,7 @@ The goal of Scour is to output a file that renders identically at a fraction of | |||
Scour is open-source and licensed under [Apache License 2.0](https://github.com/codedread/scour/blob/master/LICENSE). | |||
|
|||
Scour was originally developed by Jeff "codedread" Schiller and Louis Simard in in 2010. | |||
The project moved to GitLab in 2013 an is now maintained by Tobias "oberstet" Oberstein and Patrick "Ede_123" Storz. | |||
The project moved to GitHub in 2013 an is now maintained by Tobias "oberstet" Oberstein and Patrick "Ede_123" Storz. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
The project moved to GitHub in 2013 an is now maintained by Tobias "oberstet" Oberstein and Patrick "Ede_123" Storz. | |
The project moved to GitHub in 2013 and is now maintained by Tobias "oberstet" Oberstein and Patrick "Ede_123" Storz. |
ryandesign
reviewed
Jun 6, 2023
@@ -16,7 +16,7 @@ The goal of Scour is to output a file that renders identically at a fraction of | |||
Scour is open-source and licensed under [Apache License 2.0](https://github.com/codedread/scour/blob/master/LICENSE). | |||
|
|||
Scour was originally developed by Jeff "codedread" Schiller and Louis Simard in in 2010. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Scour was originally developed by Jeff "codedread" Schiller and Louis Simard in in 2010. | |
Scour was originally developed by Jeff "codedread" Schiller and Louis Simard in 2010. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"GitHub" instead of "GitLab"
solves #304 repored by @jwilk
Text got introduced in https://github.com/scour-project/scour/blame/f0788d5c0d49ee93e2aad44654cbc4ab22ffa70b/README.md by @Ede123 in 2017.