From 2e8db379ba5536c8d83cc0414a3e5a5f0386a1bb Mon Sep 17 00:00:00 2001
From: Carl Montanari <carl.r.montanari@gmail.com>
Date: Fri, 9 Aug 2024 15:38:02 -0700
Subject: [PATCH] chore: remove pylama/pydocstyle, just use pylint

---
 .pylintrc            |  4 +++-
 Makefile             |  2 +-
 noxfile.py           |  6 +++---
 pyproject.toml       | 10 ----------
 requirements-dev.txt |  2 --
 5 files changed, 7 insertions(+), 17 deletions(-)

diff --git a/.pylintrc b/.pylintrc
index 1beb9f4..85e4068 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -143,7 +143,7 @@ confidence=HIGH,
 # --enable=similarities". If you want to run only the classes checker, but have
 # no Warning level messages displayed, use "--disable=all --enable=classes
 # --disable=W".
-disable=C0103,C0115,R0901,R0902,R0903,R0913,R0914,W1202,W1203
+disable=C0103,C0115,R0401,R0801,R0901,R0902,R0903,R0913,R0914,W1202,W1203
 # C0103 = constant-name (a little too aggressive for some things that aren't "really" constants")
 # C0115 = class docstrings (init doc strings cover this already)
 # W1202 = use % formatting for logging (ignore, using f-strings)
@@ -153,6 +153,8 @@ disable=C0103,C0115,R0901,R0902,R0903,R0913,R0914,W1202,W1203
 # R0903 = too-few-public methods
 # R0913 = too-many-arguments
 # R0914 = too-many-local-variables
+# R0801 = similar-lines
+# R0401 = cyclic-import (too many false positives, seems like this is a common complaint :p)
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option
diff --git a/Makefile b/Makefile
index 76dff90..ae538ce 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
 lint:
 	python -m isort .
 	python -m black .
-	python -m pylama .
+	python -m pylint scrapli_netconf/
 	python -m pydocstyle .
 	python -m mypy --strict scrapli_netconf/
 
diff --git a/noxfile.py b/noxfile.py
index b8e1b71..9d27c68 100644
--- a/noxfile.py
+++ b/noxfile.py
@@ -156,9 +156,9 @@ def black(session):
 
 
 @nox.session(python=["3.11"])
-def pylama(session):
+def pylint(session):
     """
-    Nox run pylama
+    Nox run pylint
 
     Args:
         session: nox session
@@ -171,7 +171,7 @@ def pylama(session):
 
     """
     session.install(*_get_install_test_args())
-    session.run("python", "-m", "pylama", ".")
+    session.run("python", "-m", "pylint", "scrapli_netconf/")
 
 
 @nox.session(python=["3.11"])
diff --git a/pyproject.toml b/pyproject.toml
index 019e689..cfb6d8d 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -114,16 +114,6 @@ warn_unused_configs = true
 strict_optional = true
 
 
-[tool.pylama]
-linters = "mccabe,pycodestyle,pylint"
-skip = ".nox/*,.private/*,build/*,docs/*,private/*,site/*,tests/*,venv/*"
-
-[tool.pylama.pycodestyle]
-max_line_length = 100
-
-[tool.pylama.pylint]
-rcfile = ".pylintrc"
-
 [tool.pydocstyle]
 match-dir = "^scrapli_netconf/*"
 ignore = "D101,D202,D203,D212,D400,D406,D407,D408,D409,D415"
diff --git a/requirements-dev.txt b/requirements-dev.txt
index 4802a82..ecfc294 100644
--- a/requirements-dev.txt
+++ b/requirements-dev.txt
@@ -3,9 +3,7 @@ darglint>=1.8.1,<2.0.0
 isort>=5.10.1,<6.0.0
 mypy>=1.4.1,<2.0.0
 nox==2024.4.15
-pycodestyle>=2.8.0,<3.0.0
 pydocstyle>=6.1.1,<7.0.0
-pylama>=8.4.0,<9.0.0
 pylint>=3.0.0,<4.0.0
 pytest-asyncio>=0.17.0,<1.0.0
 pytest-cov>=3.0.0,<5.0.0