Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: firework (debugger logs). #8

Open
henricattoire opened this issue Dec 13, 2023 · 1 comment
Open

Bug: firework (debugger logs). #8

henricattoire opened this issue Dec 13, 2023 · 1 comment
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@henricattoire
Copy link
Contributor

henricattoire commented Dec 13, 2023

Problem:

Run vuurwerk in normal mode and in debug mode and you will see the following difference:

  • normal mode

Schermafbeelding 2023-12-13 om 15 53 37

  • debug mode

Schermafbeelding 2023-12-13 om 15 53 28

It seems like the circles do not move in a random direction when in debug mode, a lot of them share the same direction. But this block certainly tells each clone to pick a random direction:

Schermafbeelding 2023-12-13 om 15 54 04

It seems like variables are being shared among clones when logged and this is unwanted behavior.

@henricattoire henricattoire added the bug Something isn't working label Dec 13, 2023
@henricattoire henricattoire self-assigned this Dec 13, 2023
@henricattoire henricattoire changed the title Bug: vuurwerk is not random Bug: potential issue shared unwanted variables among clones. Dec 13, 2023
@henricattoire
Copy link
Contributor Author

henricattoire commented Dec 13, 2023

I think I know what the problem is. It seems like this bug only happens when the firework is fired before all (300) clones are initialized. If all clones are initialized, everything works like in normal mode.

So the problem is the following:

While the firework is firing, clones are still being created. When a clone is created, its place on the canvas is the place of the original target. This target is firing and moving forward in some direction. Because the newly created clones did not receive the bang signal, they aren't doing anything. Therefore, a long line of clones is created (following the original target) that does not go away (the bang script normally makes them fade away) until the next firework is fired.

Because the debugger logs each step and this takes some time, it takes way longer than in normal mode to initialize all clones. In normal mode it is almost instant.

@henricattoire henricattoire changed the title Bug: potential issue shared unwanted variables among clones. Bug: firework (debugger logs). Dec 13, 2023
@henricattoire henricattoire added the wontfix This will not be worked on label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant