Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scratch-gui bundled react and react-dom in its production build #9693

Open
xuanduc987 opened this issue Oct 7, 2024 · 0 comments
Open

scratch-gui bundled react and react-dom in its production build #9693

xuanduc987 opened this issue Oct 7, 2024 · 0 comments

Comments

@xuanduc987
Copy link

Expected Behavior

scratch-gui should not bundled react and react-dom package, so that the application ussing scratch-gui could provide its own version of react

Actual Behavior

From #9536, the externals of webpack config had been removed. If this was unintentional changed, I believe it should be added back (the rationale for this would be the same as the one in this PR #6754)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant