Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending "numbers" #7

Open
draco2007 opened this issue Jul 10, 2018 · 2 comments
Open

Sending "numbers" #7

draco2007 opened this issue Jul 10, 2018 · 2 comments

Comments

@draco2007
Copy link

If I send a message which only includes a number, for example "Notify(Game.time)" the python script crashes here:

https://github.com/screepers/screeps_notify/blob/master/screeps_notify/services/messengers/slack.py#L20

because the function requires a string, but recieves a number.
A possible fix would be "str(notification)", which works for strings and numbers. I don't know if the other modules are also affected.

@tedivm
Copy link
Member

tedivm commented Jul 10, 2018

I do accept pull requests :-)

@draco2007
Copy link
Author

Ok. If I find some time this week I will have a look on it.

I have some more ideas for some features or improvements. Maybe I give it a swing on the weekend =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants