Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoteJoin is not triggered on restart in specific cases #3133

Open
yakanechi opened this issue Jun 6, 2024 · 3 comments
Open

RemoteJoin is not triggered on restart in specific cases #3133

yakanechi opened this issue Jun 6, 2024 · 3 comments

Comments

@yakanechi
Copy link
Contributor

What happened:
If a RemoteJoin job has requires: [sd@2:a. sd@2:b] and a and b jobs failed, it will not be triggered even if both jobs succeed on restart.
If one of the jobs is successful, it will be triggered by Restart correctly.

First start
<- Upstream, Downstream ->

Restart from the downstream hub and success jobs
<- Upstream, Downstream ->

What you expected to happen:
Triggered remote join job if downstream jobs succeed on restart even if both failed

How to reproduce it:
Minimum configuration is as follows

Upstream

shared:
  image: node:20
  steps:
    - test: echo 'test'
    
jobs:
  hub:
    requires: [ ~commit, ~pr ]
  target:
    requires: [ sd@2:a, sd@2:b]

Downstream

shared:
  image: node:20
  steps:
    - test: echo 'test'
    
parameters:
  success: [' ', 'true', 'false']

jobs:
  hub:
    requires: [ ~sd@1:hub ]
  a:
    requires: [ ~hub ]
    steps:
      - metadata: |
          if [ "$(meta get parameters.success.value)" != 'true' ]; then
            exit 1
          fi
  b:
    requires: [ ~hub ]
    steps:
      - metadata: |
          if [ "$(meta get parameters.success.value)" != 'true' ]; then
            exit 1
          fi
@VonnyJap
Copy link
Member

VonnyJap commented Nov 6, 2024

@yakanechi - is this still an issue? Will your side be able to spend some cycle to work on this?

@yakanechi
Copy link
Contributor Author

@VonnyJap
This problem still occurs.
We can probably fix it on our end, but it may take some time.

@VonnyJap
Copy link
Member

VonnyJap commented Nov 7, 2024

@yakanechi - ok no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants