Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with HTTPS #21

Open
gka opened this issue Apr 9, 2018 · 21 comments
Open

Doesn't work with HTTPS #21

gka opened this issue Apr 9, 2018 · 21 comments

Comments

@gka
Copy link

gka commented Apr 9, 2018

the default River layout includes various JavaScript resources via HTTP. These imports fail and throw a mixed-content warning when the river is hosted on HTTPS.

Needless to say, the site is not usable without JavaScript.

Solution would be to either

I would prefer the former because I don't see why my River instance needs to depend on external websites. I assume fargo.io and nodestorage.io belong to Dave Winer, but some day he might decide to give the domains up (fargo.io already shows a retirement page).

@scripting
Copy link
Owner

I don't have an HTTPS server.

Probably should use a CDN for this.

Have to look into it.

@thejeshgn
Copy link

cdnjs ?

@scripting
Copy link
Owner

@thejeshsg -- I looked around on cdnjs and couldn't find a howto page that explained what you have to do to get a library in their CDN.

@scripting
Copy link
Owner

scripting commented Apr 12, 2018

This testimonial for jsDeliver sounds interesting.

https://www.quora.com/What-is-the-best-CDN-for-open-source-projects

It can serve from any NPM package.

@scripting
Copy link
Owner

I like jsDeliver. Here's what I've done so far.

  1. Created a river5 npm package.

  2. Tested that jsDeliver can access it.

https://cdn.jsdelivr.net/npm/river5/river5.js

That's pretty clean.

So what I would have to do if I used this, is create a folder in the repo with the content of all the included files, publish the result on NPM, then change the includes in the default files.

Probably should upload the source for the default files there too.

Then we won't be depending on http://fargo.io/ for the files, which is of course a good thing. ;-)

@scripting
Copy link
Owner

Now I'm getting an error when I try to access that file.

Package size exceeded the configured limit of 50 MB.

The river5 package isn't even 1MB. Nor is the GitHub repository.

Hard to make sense of that message.

@scripting
Copy link
Owner

The package was bigger than 50MB. My error.

We are now able to open the test file using jsdelivr.

https://cdn.jsdelivr.net/npm/river5/river5.js

@thejeshgn
Copy link

Had not see jsdeliver. It looks good and easy.

@scripting
Copy link
Owner

Made a lot of progress today on using jsdelivr as the CDN. Should have a release of River5 tomorrow that should be able to run behind HTTPS, and will not use any of my domains for serving code or stylesheets.

@scripting
Copy link
Owner

Okay the new releases of river5 and davereader are out.

That said, there are still references to fargo.io in the code.

That'll take more time to shake out because this code is shared with my other projects.

But the main files are now in jsdelivr.

Please update your River5 and watch for problems.

@mistersugar
Copy link

Not working for me. Here's what I did. Did I do the right sequence?

I stopped river5.js

ran npm update but got an error that node-gyp rebuild failed on my system. Screenshot attached.

screen shot 2018-04-14 at 11 59 47 am

tried to restart river5 but the process stops immediately.

@scripting
Copy link
Owner

scripting commented Apr 14, 2018 via email

@scripting
Copy link
Owner

scripting commented Apr 14, 2018 via email

@scripting
Copy link
Owner

Anton, was the problem resolved?

@mistersugar
Copy link

mistersugar commented Apr 15, 2018 via email

@mistersugar
Copy link

Still having trouble. Suspect this might be a permissions issue on my server. Have submitted a ticket.

@mistersugar
Copy link

mistersugar commented Apr 16, 2018

My webhost assigned execute permissions to that file (river5/lib/node_modules/npm/bin/node-gyp-bin/node-gyp), and I was able to npm update and then start river5.js with forever. The Duke River of News is back up and flowing at http://river5.dukeriver.co/

@scripting
Copy link
Owner

scripting commented Apr 16, 2018 via email

@mistersugar
Copy link

This was the file that needed permissions changed by my webhost:

river5/lib/node_modules/npm/bin/node-gyp-bin/node-gyp

@scripting
Copy link
Owner

scripting commented Apr 16, 2018 via email

@ChristophKnopf
Copy link

Hi Dave, hi Anton,
I checked all paths and the permissions for node-gyp but couldn't find missing execute rights here.

$ ll .npm-global/lib/node_modules/npm/bin/node-gyp-bin/
drwxr-xr-x 2 user user 4096 Mär 12 10:25 .
drwxr-xr-x 3 user user 4096 Mär 12 10:25 ..
-rwxr-xr-x 1 user user  172 Jan  1  1970 node-gyp
-rwxr-xr-x 1 user user  148 Jan  1  1970 node-gyp.cmd

So that seems not to be my problem. If I find a solution I will post it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants