Some include files still point to http://fargo.io #23
Comments
|
In what way do they make it not behave?
…On Tuesday, April 24, 2018, SparkyT ***@***.***> wrote:
The following 4 files in the repo and on jsdelivr.net appear to have
document.write calls to add scripts from http://fargo.io, not the new //
cdn.jsdelivr.net locations causing https instances of river5 to not work
as expected
- includes/basicincludes2/beep.js
- includes/riverBrowserIncludes/emojify.js
- includes/riverBrowserIncludes/riverbrowser.js
- includes/misc/riverbrowser.js
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#23>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABm9O3XXlze_-hnIFsp3JedhBvEYSQwJks5tr6wngaJpZM4TiiW6>
.
--
Typed on an iPad with fat fingers.
|
|
Good point - the document.write puts references to http resources which on https instances of river5 results in mixed content warnings and them being blocked. River5 then doesn't display rivers (see screenshot) |
|
Now I understand.
I can't test this stuff myself because I don't have an HTTPS server to
deploy to.
I'll work on this today. I had planned to get to this eventually. The
problem is there are other apps I have that depend on these files, and
depend on the document.write statements.
River5 doesn't depend on them, so I figured the document.writes would
generate warnings, but they wouldn't stop the app from running. Now I see
it's otherwise.
It would be helpful if you could quickly test versions, then I can iterate.
Back in a bit with something for you to try.
…On Wed, Apr 25, 2018 at 3:41 AM SparkyT ***@***.***> wrote:
Good point - the document.write puts references to http resources which on
https instances of river5 results in mixed content warnings and them being
blocked. River5 then doesn't display rivers (see screenshot)
[image: river5-docwrite]
<https://user-images.githubusercontent.com/4244537/39232179-5b420012-4864-11e8-9c42-1bc8f24d54e7.PNG>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABm9O-F9Vmze6WEk3_RkqCcZdoPe3T1Sks5tsCiXgaJpZM4TiiW6>
.
|
|
OK, to do this final (I hope) pass, I've set up a virgin River5 on my desktop. I'm looking at the home page in the browser. These are the files that are included at the top of the page. //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/alertdialog.js So these all look cool. The question is what document.writes do each of them trigger? |
|
BTW, I have steps-to-reproduce, and through the magic of jsdelivr, I believe I will be able to fix this problem without you having to test. I noticed the URL in your screen shot, a familiar one, with https instead of http. Boom, that page doesn't load and when I look at the console there are the errors. |
|
@SparkyT -- in order to get this debugged, I need you to do an Thanks for all your help with this. Very cool. ;-) |
|
@scripting - no problem, it's interesting being involved in something that someone else has created.
Given we have the chance now before it is really publicised do you want to change the glitch name from newriver5 to something else? |
|
@SparkyT -- this is great. ;-)
|
The following 4 files in the repo and on jsdelivr.net appear to have document.write calls to add scripts from http://fargo.io, not the new //cdn.jsdelivr.net locations causing https instances of river5 to not work as expected
The text was updated successfully, but these errors were encountered: